rds_instance: fix promotion_tier type #1475
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 10s |
There was a problem hiding this comment.
Looks good, please could you add a changelog entry: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
| @@ -334,7 +334,7 @@ | |||
| description: | |||
| - An integer that specifies the order in which an Aurora Replica is promoted to the primary instance after a failure of | |||
| the existing primary instance. | |||
| type: str | |||
There was a problem hiding this comment.
nominally this would be a "breaking" change, however passing anything here would currently result in an exception, so I think we let this pass.
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 03s |
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply bc3ee14 on top of patchback/backports/stable-5/bc3ee145f341a39b532eb32aab503411b0b7ebfe/pr-1475 Backporting merged PR #1475 into main
🤖 @patchback |
rds_instance: fix promotion_tier type SUMMARY Change promotion_tier type to integer ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
…le-collections#1475) tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error Ensures the "test failure with non-existent VPC ID" test uses a properly formatted VPC ID. Otherwise, the API now returns the following error: "error": { "code": "InvalidVpcId.Malformed", "message": "The vpc ID vpc-012345678 is malformed" }, Reviewed-by: Mark Chappell <None>
…le-collections#1475) tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error Ensures the "test failure with non-existent VPC ID" test uses a properly formatted VPC ID. Otherwise, the API now returns the following error: "error": { "code": "InvalidVpcId.Malformed", "message": "The vpc ID vpc-012345678 is malformed" }, Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fe83fcb
…le-collections#1475) tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error Ensures the "test failure with non-existent VPC ID" test uses a properly formatted VPC ID. Otherwise, the API now returns the following error: "error": { "code": "InvalidVpcId.Malformed", "message": "The vpc ID vpc-012345678 is malformed" }, Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fe83fcb
…le-collections#1475) tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error Ensures the "test failure with non-existent VPC ID" test uses a properly formatted VPC ID. Otherwise, the API now returns the following error: "error": { "code": "InvalidVpcId.Malformed", "message": "The vpc ID vpc-012345678 is malformed" }, Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fe83fcb
SUMMARY
Change promotion_tier type to integer
ISSUE TYPE
COMPONENT NAME
rds_instance.py
ADDITIONAL INFORMATION