Lambda execute stack trace should be not formatted with extra space #1615

                "trace": "\n".join(
                    [
-                        " ".join([str(x) for x in line])  # cast line numbers to strings
-                        for line in results.get("output", {}).get("stackTrace", [])
+                        list(results.get("output", {}).get("stackTrace", []))
                    ]
                ),


I think this can just be replaced with:

"trace": "\n".join(results.get("output", {}).get("stackTrace", []))

Also, worth noting that [i for i in somelist] is different than [list(somelist)] as the latter will produce a nested list.

softwarefactory-project-zuul · 2023-06-22T14:57:30Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8ff5e7ace6734e6a8dd36cf879736bb8

❌ ansible-galaxy-importer ERROR Failed to update project ansible-collections/amazon.aws in 0s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 10m 27s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-06-22T16:40:45Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6681f0b7a84e4be7a6bfcece92a6b5f6

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 13m 48s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-amazon.aws-1 SUCCESS in 9m 12s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-06-27T09:46:32Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/a69d2af65d2d49138a7f7cd106fc74f2

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 12m 55s
✔️ ansible-test-splitter SUCCESS in 5m 13s
❌ integration-amazon.aws-1 FAILURE in 8m 13s
Skipped 43 jobs

gravesm · 2023-06-27T15:48:50Z

We should be able to regate this when #1625 is merged.

gravesm · 2023-06-27T17:01:44Z

regate

softwarefactory-project-zuul · 2023-06-27T17:26:28Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/472ae54f64fd47008d63e807e4462169

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 12m 49s
✔️ ansible-test-splitter SUCCESS in 5m 11s
✔️ integration-amazon.aws-1 SUCCESS in 10m 30s
Skipped 43 jobs

patchback · 2023-06-27T17:26:32Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 271523e on top of patchback/backports/stable-5/271523ea97f73f0e4c5a027eac4f4fc72f4b7093/pr-1615

Backporting merged PR #1615 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/271523ea97f73f0e4c5a027eac4f4fc72f4b7093/pr-1615 upstream/stable-5

Now, cherry-pick PR Lambda execute stack trace should be not formatted with extra space #1615 contents into that branch:
```
$ git cherry-pick -x 271523ea97f73f0e4c5a027eac4f4fc72f4b7093
```
If it'll yell at you with something like fatal: Commit 271523ea97f73f0e4c5a027eac4f4fc72f4b7093 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 271523ea97f73f0e4c5a027eac4f4fc72f4b7093
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Lambda execute stack trace should be not formatted with extra space #1615 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/271523ea97f73f0e4c5a027eac4f4fc72f4b7093/pr-1615

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2023-06-27T17:26:39Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/271523ea97f73f0e4c5a027eac4f4fc72f4b7093/pr-1615

Backported as #1628

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…1615) Lambda execute stack trace should be not formatted with extra space SUMMARY Fixes #1497 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 271523e)

github-actions · 2023-06-27T18:32:58Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

…nsible-collections#1615) Lambda execute stack trace should be not formatted with extra space SUMMARY Fixes ansible-collections#1497 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 271523e)

…1615) (#1634) [manual backport stable-5] Lambda execute stack trace should be not formatted with extra space …#1615) Lambda execute stack trace should be not formatted with extra space SUMMARY Fixes #1497 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves mgraves@redhat.com (cherry picked from commit 271523e) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Helen Bailey <hebailey@redhat.com>

…1615) (#1628) [PR #1615/271523ea backport][stable-6] Lambda execute stack trace should be not formatted with extra space This is a backport of PR #1615 as merged into main (271523e). SUMMARY Fixes #1497 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Alina Buzachis

change from receiving a list of strings to a string

9c545f2

added fragments

9712d98

taehopark32 changed the title ~~[WIP] Lambda execute stack trace should be not formatted with extra space~~ Lambda execute stack trace should be not formatted with extra space Jun 21, 2023

change fragment name

9d318d9

jillr reviewed Jun 21, 2023

View reviewed changes

changelogs/fragments/1615-no_formatted_with_extra_space.yml Outdated Show resolved Hide resolved

abikouo approved these changes Jun 22, 2023

View reviewed changes

Update changelogs/fragments/1615-no_formatted_with_extra_space.yml

ab3d1d7

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>

alinabuzachis approved these changes Jun 22, 2023

View reviewed changes

alinabuzachis added backport-6 PR should be backported to the stable-6 branch backport-5 PR should be backported to the stable-5 branch labels Jun 22, 2023

used more concise coding for listing stack trace

8cfeaae

gravesm reviewed Jun 22, 2023

View reviewed changes

more concise of retrieving stack trace

90476f3

gravesm approved these changes Jun 22, 2023

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 27, 2023

softwarefactory-project-zuul bot merged commit 271523e into ansible-collections:main Jun 27, 2023

patchback bot mentioned this pull request Jun 27, 2023

[PR #1615/271523ea backport][stable-6] Lambda execute stack trace should be not formatted with extra space #1628

Merged

alinabuzachis mentioned this pull request Jun 30, 2023

[manual backport stable-5] Lambda execute stack trace should be not formatted with extra space #1634

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lambda execute stack trace should be not formatted with extra space #1615

Lambda execute stack trace should be not formatted with extra space #1615

taehopark32 commented Jun 16, 2023

softwarefactory-project-zuul bot commented Jun 16, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

gravesm Jun 22, 2023

gravesm Jun 22, 2023

softwarefactory-project-zuul bot commented Jun 22, 2023

softwarefactory-project-zuul bot commented Jun 22, 2023

softwarefactory-project-zuul bot commented Jun 27, 2023

gravesm commented Jun 27, 2023

gravesm commented Jun 27, 2023

softwarefactory-project-zuul bot commented Jun 27, 2023

patchback bot commented Jun 27, 2023 •

edited

Loading

patchback bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023

Lambda execute stack trace should be not formatted with extra space #1615

Lambda execute stack trace should be not formatted with extra space #1615

Conversation

taehopark32 commented Jun 16, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Jun 16, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

gravesm Jun 22, 2023

Choose a reason for hiding this comment

gravesm Jun 22, 2023

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 22, 2023

softwarefactory-project-zuul bot commented Jun 22, 2023

softwarefactory-project-zuul bot commented Jun 27, 2023

gravesm commented Jun 27, 2023

gravesm commented Jun 27, 2023

softwarefactory-project-zuul bot commented Jun 27, 2023

patchback bot commented Jun 27, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1615 into main

patchback bot commented Jun 27, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

github-actions bot commented Jun 27, 2023

Docs Build 📝

patchback bot commented Jun 27, 2023 •

edited

Loading

patchback bot commented Jun 27, 2023 •

edited

Loading