ec2_ami: Add support for OrganizationArn and OrganizationalUnitArn #1690
Conversation
ansibullbot
added
WIP
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
mandar242
force-pushed
the
ec2_ami_org_orgu_arn
branch
from
668d534
to
ccc2cf6
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s |
mandar242
force-pushed
the
ec2_ami_org_orgu_arn
branch
from
ccc2cf6
to
62b3bcf
Compare
mandar242
changed the title
ansibullbot
added
community_review
integration
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 11s |
mandar242
force-pushed
the
ec2_ami_org_orgu_arn
branch
from
62b3bcf
to
4803612
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 07s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 18s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
There was a problem hiding this comment.
I might be wrong, but these suboptions were already present in launch_permissions, am I wrong? If so, this should be more like a bugfix (meaning we can also backport to stable-5).
There was a problem hiding this comment.
I'm not sure if I'm getting the question correctly but
in module ec2_ami.py, the options org_arns and org_unit_arns were not present before this PR
but the options OrganizationArn & OrganizationalUnitArn have been LaunchPermissions supported in boto3 from 1.20.0
https://boto3.amazonaws.com/v1/documentation/api/1.20.0/reference/services/ec2.html?highlight=modify_image_attribute#EC2.Client.modify_image_attribute
please let me know if that answers the question
mandar242
added
mergeit
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 13s |
|
regate |
hakbailey
added
mergeit
hakbailey
force-pushed
the
ec2_ami_org_orgu_arn
branch
from
56c6c4c
to
215d771
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 51s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 53s |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1735 🤖 @patchback |
…1690) * Add support for OrganizationArn and OrganizationalUnitArn in launch_permissions * doc fixes * add changelogs fragment * formating fixes * add integration test * modify launch_permissions to have suboptions * minor fix * sanity fix * linter fix * Add version_added for new options --------- Co-authored-by: Helen Bailey <hebailey@redhat.com> (cherry picked from commit c51c225)
…1690) (#1735) [PR #1690/c51c2255 backport][stable-6] ec2_ami: Add support for OrganizationArn and OrganizationalUnitArn This is a backport of PR #1690 as merged into main (c51c225). SUMMARY Fixes #970 Added support for OrganizationArn and OrganizationalUnitArn in launch permissions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_ami ADDITIONAL INFORMATION https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ModifyImageAttribute.html Reviewed-by: Mark Chappell
8.5.0 amazon.aws ~~~~~~~~~~ - ec2_ami - add support for ``org_arns`` and ``org_unit_arns`` in launch_permissions (ansible-collections/amazon.aws#1690). - elb_application_lb_info - drop redundant ``describe_load_balancers`` call fetching ``ip_address_type`` (ansible-collections/amazon.aws#1768). community.general ~~~~~~~~~~~~~~~~~ - cargo - add option ``executable``, which allows user to specify path to the cargo binary (ansible-collections/community.general#7352). - cargo - add option ``locked`` which allows user to specify install the locked version of dependency instead of latest compatible version (ansible-collections/community.general#6134). - dig lookup plugin - add TCP option to enable the use of TCP connection during DNS lookup (ansible-collections/community.general#7343). - gitlab_group - add option ``force_delete`` (default: false) which allows delete group even if projects exists in it (ansible-collections/community.general#7364). - ini_file - add ``ignore_spaces`` option (ansible-collections/community.general#7273). - newrelic_deployment - add option ``app_name_exact_match``, which filters results for the exact app_name provided (ansible-collections/community.general#7355). - onepassword lookup plugin - introduce ``account_id`` option which allows specifying which account to use (ansible-collections/community.general#7308). - onepassword_raw lookup plugin - introduce ``account_id`` option which allows specifying which account to use (ansible-collections/community.general#7308). - parted - on resize, use ``--fix`` option if available (ansible-collections/community.general#7304). - pnpm - set correct version when state is latest or version is not mentioned. Resolves previous idempotency problem (ansible-collections/community.general#7339). - proxmox - add ``vmid`` (and ``taskid`` when possible) to return values (ansible-collections/community.general#7263). - random_string - added new ``ignore_similar_chars`` and ``similar_chars`` option to ignore certain chars (ansible-collections/community.general#7242). - redfish_command - add new option ``update_oem_params`` for the ``MultipartHTTPPushUpdate`` command (ansible-collections/community.general#7331). - redfish_config - add ``CreateVolume`` command to allow creation of volumes on servers (ansible-collections/community.general#6813). - redfish_config - adding ``SetSecureBoot`` command (ansible-collections/community.general#7129). - redfish_info - add support for ``GetBiosRegistries`` command (ansible-collections/community.general#7144). - redfish_info - adds ``LinkStatus`` to NIC inventory (ansible-collections/community.general#7318). - redis_info - refactor the redis_info module to use the redis module_utils enabling to pass TLS parameters to the Redis client (ansible-collections/community.general#7267). - supervisorctl - allow to stop matching running processes before removing them with ``stop_before_removing=true`` (ansible-collections/community.general#7284). community.libvirt ~~~~~~~~~~~~~~~~~ - virt - add `mutate_flags` parameter to enable XML mutation (add UUID, MAC addresses from existing domain) (ansible-collections/community.libvirt#142). - virt - support ``--diff`` for ``define`` command (ansible-collections/community.libvirt#142). community.routeros ~~~~~~~~~~~~~~~~~~ - api_info - add new ``include_read_only`` option to select behavior for read-only values. By default these are not returned (ansible-collections/community.routeros#213). - api_info, api_modify - add support for ``address-list`` and ``match-subdomain`` introduced by RouterOS 7.7 in the ``ip dns static`` path (ansible-collections/community.routeros#197). - api_info, api_modify - add support for ``user``, ``time`` and ``gmt-offset`` under the ``system clock`` path (ansible-collections/community.routeros#210). - api_info, api_modify - add support for the ``interface ppp-client`` path (ansible-collections/community.routeros#199). - api_info, api_modify - add support for the ``interface wireless`` path (ansible-collections/community.routeros#195). - api_info, api_modify - add support for the ``iot modbus`` path (ansible-collections/community.routeros#205). - api_info, api_modify - add support for the ``ip dhcp-server option`` and ``ip dhcp-server option sets`` paths (ansible-collections/community.routeros#223). - api_info, api_modify - add support for the ``ip upnp interfaces``, ``tool graphing interface``, ``tool graphing resource`` paths (ansible-collections/community.routeros#227). - api_info, api_modify - add support for the ``ipv6 firewall nat`` path (ansible-collections/community.routeros#204). - api_info, api_modify - add support for the ``mode`` property in ``ip neighbor discovery-settings`` introduced in RouterOS 7.7 (ansible-collections/community.routeros#198). - api_info, api_modify - add support for the ``port remote-access`` path (ansible-collections/community.routeros#224). - api_info, api_modify - add support for the ``routing filter rule`` and ``routing filter select-rule`` paths (ansible-collections/community.routeros#200). - api_info, api_modify - add support for the ``routing table`` path in RouterOS 7 (ansible-collections/community.routeros#215). - api_info, api_modify - add support for the ``tool netwatch`` path in RouterOS 7 (ansible-collections/community.routeros#216). - api_info, api_modify - add support for the ``user settings`` path (ansible-collections/community.routeros#201). - api_info, api_modify - add support for the ``user`` path (ansible-collections/community.routeros#211). - api_info, api_modify - finalize fields for the ``interface wireless security-profiles`` path and enable it (ansible-collections/community.routeros#203). - api_info, api_modify - finalize fields for the ``ppp profile`` path and enable it (ansible-collections/community.routeros#217). - api_modify - add new ``handle_read_only`` and ``handle_write_only`` options to handle the module's behavior for read-only and write-only fields (ansible-collections/community.routeros#213). - api_modify, api_info - support API paths ``routing id``, ``routing bgp connection`` (ansible-collections/community.routeros#220). community.vmware ~~~~~~~~~~~~~~~~ - add moid property in the return value for the module(ansible-collections/community.vmware#1855). - add new snapshot_id option to the vmware_guest_snapshot module(ansible-collections/community.vmware#1847). dellemc.powerflex ~~~~~~~~~~~~~~~~~ - Added Ansible role to support installation and uninstallation of Gateway. - Added Ansible role to support installation and uninstallation of SDR. - Added Ansible role to support installation and uninstallation of Web UI. grafana.grafana ~~~~~~~~~~~~~~~ - Add check for Curl and failure step if Agent Version is not retrieved - Allow alert resource provisioning in Grafana Role - Bump cryptography from 39.0.2 to 41.0.3 - Bump cryptography from 41.0.3 to 41.0.4 - Bump semver from 5.7.1 to 5.7.2 - Bump word-wrap from 1.2.3 to 1.2.5 - Create local dashboard directory in check mode - Create missing notification directory in Grafana Role - Remove check_mode from create local directory task in Grafana Role - Remove dependency on local-fs.target from Grafana Agent role - Update CI Testing - Update Cloud Stack Module failures - Use 'ansible_system' env variable to detect os typ in Grafana Agent Role - hange grafana Agent Wal and Positions Directory in Grafana Agent Role ovirt.ovirt ~~~~~~~~~~~ - ovirt_vm - Add tpm_enabled (oVirt/ovirt-ansible-collection#722). - storage_error_resume_behaviour - Support VM storage error resume behaviour "auto_resume", "kill", "leave_paused". (oVirt/ovirt-ansible-collection#721) - vm_infra - Support boot disk renaming and resizing. (oVirt/ovirt-ansible-collection#705) purestorage.flashblade ~~~~~~~~~~~~~~~~~~~~~~ - purefb_bucket_replica - Added support for cascading replica links - purefb_info - New fields to display free space (remaining quota) for Accounts and Buckets. Space used by destroyed buckets is split out from virtual field to new destroyed_virtual field - purefb_info - Report encryption state in SMB client policy rules - purefb_info - Report more detailed space data from Purity//FB 4.3.0 - purefb_policy - Add deny effect for object store policy rules. Requires Purity//FB 4.3.0+ - purefb_policy - Added parameter to define object store policy description vultr.cloud ~~~~~~~~~~~ - inventory - Added VPC/VPC 2.0 support by adding ``internal_ip`` to the attributes (vultr/ansible-collection-vultr#86).
Fix copying of empty file SUMMARY Fixes ansible-collections#1686. Basically it is a workaround for curl, which did not create empty files when using the -o flag (curl/curl#183). Although this issue was fixed in 2015, 'actively maintained operating systems' still use older of it (e.g. CentOS 7) ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I was not able to test it yet in a relevant environment (e.g. with CentOS 7), will do so shortly. Reviewed-by: Bence Hornák <None> Reviewed-by: Mark Chappell <None>
SUMMARY
Fixes #970
Added support for OrganizationArn and OrganizationalUnitArn in launch permissions.
ISSUE TYPE
COMPONENT NAME
ec2_ami
ADDITIONAL INFORMATION
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ModifyImageAttribute.html