[manual backport stable-6] ec2_key - fix security vulnerability (#1704) #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP: begin swapping out private key data for key file Start sketching out unit tests * ec2_key - update module return private_key and add new parameter path defining path to a file to store private key when creating new key pair * fix changelog file * fix additional sanity issues * ec2_key - Remove breaking_change feature, add new parameter to save private key in * Code review updates * Refactoring * Remove key_info * Doc fixes * Uncomment call to ec2_key_info in tests * Add key_info runtume.yml --------- Co-authored-by: Jill Rouleau <jill.rouleau@bespokess.com> Co-authored-by: GomathiselviS <gomathiselvi@gmail.com> (cherry picked from commit 1a077fb)
GomathiselviS
approved these changes
Sep 1, 2023
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 08s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 59s |
softwarefactory-project-zuul
bot
merged commit 2c4c43b
into
ansible-collections:stable-6
63 checks passed
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#1724) lightsail: add support for firewall ports and snapshot management SUMMARY Created a new module called lightsail_snapshot that allows to create and delete snapshots of instances already created. Add functionality to module lightsail to define the firewall ports. Fixes ansible-collections#174 ISSUE TYPE Feature Pull Request New Module Pull Request COMPONENT NAME lightsail lightsail_snapshot Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#1724) lightsail: add support for firewall ports and snapshot management SUMMARY Created a new module called lightsail_snapshot that allows to create and delete snapshots of instances already created. Add functionality to module lightsail to define the firewall ports. Fixes ansible-collections#174 ISSUE TYPE Feature Pull Request New Module Pull Request COMPONENT NAME lightsail lightsail_snapshot Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…sible-collections#1724) lightsail: add support for firewall ports and snapshot management SUMMARY Created a new module called lightsail_snapshot that allows to create and delete snapshots of instances already created. Add functionality to module lightsail to define the firewall ports. Fixes ansible-collections#174 ISSUE TYPE Feature Pull Request New Module Pull Request COMPONENT NAME lightsail lightsail_snapshot Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start sketching out unit tests
ec2_key - update module return private_key and add new parameter path defining path to a file to store private key when creating new key pair
fix changelog file
fix additional sanity issues
ec2_key - Remove breaking_change feature, add new parameter to save private key in
Code review updates
Refactoring
Remove key_info
Doc fixes
Uncomment call to ec2_key_info in tests
Add key_info runtume.yml
Co-authored-by: Jill Rouleau jill.rouleau@bespokess.com
Co-authored-by: GomathiselviS gomathiselvi@gmail.com
(cherry picked from commit 1a077fb)
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION