[PR #2222/0dbac7a7 backport][stable-8] s3_bucket - remove default for accelerate_enabled #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
SUMMARY fixes #2220 Removes the default for accelerate_enabled: having the default explicitly set to false breaks idempotency when only passed partial configuration having the default explicitly set results in the module always failing on non-AWS platforms ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 0dbac7a)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Aug 21, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 31s |
softwarefactory-project-zuul
bot
merged commit 5e6b35c
into
stable-8
34 of 37 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-8/0dbac7a748f143811d5d3d82e5dd38b5e3aba3f0/pr-2222
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2222 as merged into main (0dbac7a).
SUMMARY
fixes #2220
Removes the default for accelerate_enabled:
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION