Use hash of hostname for s3_bucket's bucket name #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zuul CI hostnames cause bucket names in tests to exceed S3's allowable 63 characters
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ble-collections#535) * fix issue ansible-collections#343 for missing AWS_SESSION_TOKEN
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ollections#514) aws_ssm connection - Move connection vars environment handling into options SUMMARY This fix moves a number of connection related variables to the options parsing step instead of inline. This has the added effect of documenting their existence and making overriding them more consistent with Ansible's UX. Fixes ansible-collections#343 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION There were a couple of other minor changes related to logging and silencing curl's progress info outside of the connection vars themselves. I'm happy to pull them out if desired and submit them as a separate PR. I added fallback on hostnames lookup to match SSH's host handling since that's the defacto connection plugin. This incidentally fixes the way delegation is reported (it didn't show the -> delegated host bit in the logs). Of note, the ec2.py module sets the instance_id and placement on instances it detects so I added it as first-class fallback for instance_id and region parameters respectively. The get_options parser doesn't handle nested variable lookups, so I had to modify the lookup slightly. Reviewed-by: Jill R <None> Reviewed-by: Guillaume GILL <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Zuul CI hostnames cause bucket names in tests to exceed S3's allowable 63 characters
ISSUE TYPE
COMPONENT NAME
tests/integration/targets/s3_bucket/roles/s3_bucket/defaults/main.yml
ADDITIONAL INFORMATION
For example:
https://4b2ae1954e8e64a484dc-1b1d0bfad31e0b3f9500a4be3dccc5f5.ssl.cf2.rackcdn.com/311/6f131890a25a1399b229b959eb33f33d89671f0f/check/ansible-test-cloud-integration-aws-py36/614888e/job-output.html#l1773
ansible-test-11129663-centos-8-1vcpu-limestone-us-dfw-1-0001381.something