ec2_elb_lb boto3 migration #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
tremble
force-pushed
the
boto3/ec2_elb_lb
branch
from
e4f95ef
to
b59106a
Compare
This comment has been minimized.
This comment has been minimized.
ansibullbot
added
new_module
|
following up on our irc convo, I'm +1 to ec2_classic_lb with redirects (the ec2 classic announcements read like classic ELBs will also be retired, but I'm skimming quickly so I could have missed something) |
tremble
force-pushed
the
boto3/ec2_elb_lb
branch
6 times, most recently
from
ec11588
to
15fc9ce
Compare
Closed
1 task
tremble
force-pushed
the
boto3/ec2_elb_lb
branch
from
15fc9ce
to
6f98a2b
Compare
This comment has been minimized.
This comment has been minimized.
tremble
force-pushed
the
boto3/ec2_elb_lb
branch
from
6f98a2b
to
d50fe50
Compare
tremble
force-pushed
the
boto3/ec2_elb_lb
branch
from
6b2a0d6
to
c1e29d2
Compare
|
@jillr I've re-added the 'fact' (for what little a hard-coded value is worth). As such we should be able to land this in a normal minor release rather than this needing to wait for a major release. There are a couple of similar 'facts' over in community.aws that we should probably prune at the same time we clean out all of the _fact aliases, and just have 3.0 labeled as our big "fact" cleanup. |
This comment has been minimized.
This comment has been minimized.
|
recheck |
alinabuzachis
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
All this seems good to me! Thank you @tremble, the review took more than I expected.
tremble
commented
Sep 28, 2021
plugins/modules/elb_classic_lb.py
Outdated
| description: | ||
| - Creates, updates or destroys an Amazon Elastic Load Balancer (ELB). | ||
| - This module was renamed from M(ec2_elb_lb) to M(elb_classic_lb) in version | ||
| 2.0.0 of the amazon.aws collection. |
There was a problem hiding this comment.
Suggested change
| 2.0.0 of the amazon.aws collection. | |
| 2.1.0 of the amazon.aws collection. |
We missed 2.0.0
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
elb_classic_lb - deprecate the ec2_elb fact SUMMARY deprecates the ec2_elb fact in favour of the elb return value. Split off from #377 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_classic_lb ADDITIONAL INFORMATION (yes, this module set a fact with the same name, but different content, as the elb_instance module.) Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 25, 2022
elb_classic_lb - Remove deprecated ec2_elb fact SUMMARY Remove previously deprecated ec2_elb fact from elb_classic_lb this only every returned the value 'info'. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_classic_lb ADDITIONAL INFORMATION See also #552 and #377 for some of the history. Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rewrite ec2_elb_lb using the boto3 SDK
ISSUE TYPE
COMPONENT NAME
ec2_elb_lb
ADDITIONAL INFORMATION
Current state
Depends-On: ansible/ansible-zuul-jobs#1097