-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters. #544
Merged
ansible-zuul
merged 2 commits into
ansible-collections:main
from
tremble:vpc_endpoint/subnets
Oct 25, 2021
Merged
ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters. #544
ansible-zuul
merged 2 commits into
ansible-collections:main
from
tremble:vpc_endpoint/subnets
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eses varibales are used when you create an Interface type endpoint
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
labels
Oct 22, 2021
tremble
changed the title
ec2_vpc_endpoint Add vpc_endpint_subnets and vpc_endpoint_security_groups variable.
ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters.
Oct 22, 2021
alinabuzachis
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for setting the subnet and security group used by the Endpoint
ISSUE TYPE
COMPONENT NAME
ec2_vpc_endpoint
ADDITIONAL INFORMATION
Originally submitted as ansible-collections/community.aws#589