Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters. #544

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 22, 2021

SUMMARY

Add support for setting the subnet and security group used by the Endpoint

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_endpoint

ADDITIONAL INFORMATION

Originally submitted as ansible-collections/community.aws#589

mickael.roger and others added 2 commits October 22, 2021 14:13
…eses varibales are used when you create an Interface type endpoint
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 22, 2021
@tremble tremble changed the title ec2_vpc_endpoint Add vpc_endpint_subnets and vpc_endpoint_security_groups variable. ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters. Oct 22, 2021
@tremble tremble added the gate label Oct 25, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit f8a830b into ansible-collections:main Oct 25, 2021
@tremble tremble deleted the vpc_endpoint/subnets branch November 26, 2021 12:41
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ctions#771)

add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: ansible-collections#544

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ctions#771)

add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: ansible-collections#544

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ctions#771)

add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: ansible-collections#544

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants