rds module_util - fix check_mode and idempotence bugs and support adding/removing IAM roles #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
jatorcasso
force-pushed
the
module_util/rds_iam_roles
branch
from
a651952
to
c3e656c
Compare
jatorcasso
force-pushed
the
module_util/rds_iam_roles
branch
from
4e06461
to
0e34d25
Compare
|
recheck |
jatorcasso
force-pushed
the
module_util/rds_iam_roles
branch
from
4ae27a4
to
ee09a4a
Compare
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Apr 12, 2022
…/removing iam roles (#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes #464 Fixes #1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections/amazon.aws#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
patchback bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Apr 12, 2022
…/removing iam roles (#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes #464 Fixes #1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections/amazon.aws#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit c403552)
jatorcasso
added a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Apr 12, 2022
…ing/removing IAM roles (ansible-collections#714) rds module_util - fix check_mode and idempotence bugs and support adding/removing IAM roles SUMMARY Add waiter for promoting read replica to fix idempotence bug in community.aws integration testing Support modifying IAM roles to a db instance for ansible-collections/community.aws#1002 Add necessary waiters for both adding and removing an IAM role compare and ensure iam_roles methods for idempotency unit & integration tests for coverage (integration tests in community.aws PR) ISSUE TYPE Feature Pull Request COMPONENT NAME module_util/rds community.aws.rds_instance ADDITIONAL INFORMATION Refs: (adding role) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/add-role-to-db-instance.html (removing role) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/remove-role-from-db-instance.html (waiters) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/describe-db-instances.html Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Jill R <None> Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 00c752e)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Apr 16, 2022
…/removing iam roles (#1002) (#1055) [PR #1002/c403552f backport][stable-3] rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles This is a backport of PR #1002 as merged into main (c403552). SUMMARY Support the addition and deletion of iam roles to db instances Fixes #464 Fixes #1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections/amazon.aws#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de>
1 task
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
1 task
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…finition/placement-option ecs_taskdefinition - add placement_constraints option Depends-On: ansible/ansible-zuul-jobs#1179 SUMMARY Add placement_constraints option. Fixes: ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_taskdefinition Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…finition/placement-option ecs_taskdefinition - add placement_constraints option Depends-On: ansible/ansible-zuul-jobs#1179 SUMMARY Add placement_constraints option. Fixes: ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_taskdefinition Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Refs: