Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_net - Deprecate purge_tags=False and support management by ID #848

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 28, 2022

Depends-On: #844

SUMMARY

Deprecate purge_tags=False and support managing VPCs by ID which lets us change tags

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_net

ADDITIONAL INFORMATION
  • Integration test for management by ID

@github-actions
Copy link

github-actions bot commented May 28, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels May 28, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the tagging/deprecate_purge/ec2_vpc_net branch from 404eeed to 6c5245e Compare May 28, 2022 15:02
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the tagging/deprecate_purge/ec2_vpc_net branch from 6c5245e to 6b2cb78 Compare May 28, 2022 18:04
@softwarefactory-project-zuul

This comment was marked as resolved.

@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels May 29, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the tagging/deprecate_purge/ec2_vpc_net branch from 67b8546 to 6912063 Compare May 30, 2022 05:21
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble changed the title ec2_vpc_net - Deprecate purge_tags=False and support management by ID [WIP] ec2_vpc_net - Deprecate purge_tags=False and support management by ID May 30, 2022
@ansibullbot ansibullbot added the WIP Work in progress label May 30, 2022
@tremble tremble force-pushed the tagging/deprecate_purge/ec2_vpc_net branch from 6912063 to ba3ea57 Compare May 30, 2022 11:26
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the tagging/deprecate_purge/ec2_vpc_net branch from ba3ea57 to 6f81780 Compare May 30, 2022 11:53
@tremble tremble changed the title [WIP] ec2_vpc_net - Deprecate purge_tags=False and support management by ID ec2_vpc_net - Deprecate purge_tags=False and support management by ID May 30, 2022
@tremble tremble removed the WIP Work in progress label May 30, 2022
@tremble
Copy link
Contributor Author

tremble commented May 30, 2022

@markuman @alinabuzachis This turned into somewhat more of a refactor than a just purge_tags and management by ID...

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 4m 47s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 33s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 12m 27s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 11s
✔️ ansible-test-splitter SUCCESS in 3m 25s
✔️ integration-amazon.aws-1 SUCCESS in 8m 42s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 25m 58s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Co-authored-by: Markus Bergholz <git@osuv.de>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 5m 01s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 42s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 14m 19s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 48s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-amazon.aws-1 SUCCESS in 8m 16s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 31, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 5m 01s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 34s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 11m 34s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 48s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 55s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-amazon.aws-1 SUCCESS in 8m 59s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 240a0ea into ansible-collections:main May 31, 2022
@tremble tremble deleted the tagging/deprecate_purge/ec2_vpc_net branch September 9, 2022 08:50
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
 Prepare for community.aws release 3.0.0

SUMMARY
next major release
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
everything

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ca5ef92
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
 Prepare for community.aws release 3.0.0

SUMMARY
next major release
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
everything

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ca5ef92
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
 Prepare for community.aws release 3.0.0

SUMMARY
next major release
ISSUE TYPE


Feature Pull Request

COMPONENT NAME
everything

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants