new module: s3_object_info #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandar242
requested review from
tremble,
gravesm,
markuman,
jillr and
alinabuzachis
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
WIP
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tremble
previously requested changes
Aug 25, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
changed the title
tremble
reviewed
Sep 6, 2022
ansibullbot
added
community_review
and removed
needs_revision
| return False | ||
|
|
||
|
|
||
| def get_s3_connection(module, aws_connect_kwargs, location, ceph, endpoint_url, sig_4=False): |
There was a problem hiding this comment.
We can keep it as it is for the moment. For the future, we should move this in module_utils instead of introducing redundancy and refactor the other s3 modules as needed.
There was a problem hiding this comment.
Agreed. Makes sense.
Once this (and other s3 PRs if any) are merged, I can work on refactoring this.
|
recheck |
alinabuzachis
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
@mandar242 You should also add s3_object_info here https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/s3_object/aliases
Other than that, LGTM! Thank you @mandar242
jillr
approved these changes
Sep 27, 2022
mandar242
added
mergeit
|
regate |
alinabuzachis
dismissed stale reviews from goneri and tremble
Requested changes have been addressed. It hangs on gating.
|
regate |
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Add backoff logic to elb_application_lb_info SUMMARY From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability. fatal: [127.0.0.1 -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Failed to list load balancers: An error occurred (Throttling) when calling the DescribeLoadBalancers operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: content-length: '271' content-type: text/xml date: Thu, 10 Mar 2022 10:34:23 GMT x-amzn-requestid: xxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Add backoff logic to elb_application_lb_info SUMMARY From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability. fatal: [127.0.0.1 -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Failed to list load balancers: An error occurred (Throttling) when calling the DescribeLoadBalancers operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: content-length: '271' content-type: text/xml date: Thu, 10 Mar 2022 10:34:23 GMT x-amzn-requestid: xxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add backoff logic to elb_application_lb_info SUMMARY From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability. fatal: [127.0.0.1 -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Failed to list load balancers: An error occurred (Throttling) when calling the DescribeLoadBalancers operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: content-length: '271' content-type: text/xml date: Thu, 10 Mar 2022 10:34:23 GMT x-amzn-requestid: xxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a new module for retrieving s3 object info.
Currently supports following boto APIs
get_object()
get_object_acl()
get_object_attributes()
get_object_legal_hold()
get_object_lock_configuration()
get_object_retention()
get_object_tagging()
ISSUE TYPE
COMPONENT NAME
s3_object_info
ADDITIONAL INFORMATION
Sample Tasks: