Handle absence of classic link support for shared VPCs #984

GomathiselviS · 2022-08-29T21:16:36Z

Signed-off-by: GomathiselviS gomathiselvi@gmail.com

SUMMARY

Fixes #663

One of the Classic Link Limitations is that

You cannot link an EC2-Classic instance to a VPC that's in a different Region or a different AWS account..

When calling the DescribeVpcClassicLink operation on a shared VPC, it errors out saying "The vpc ID 'vpc-xxxx' does not exist".
This PR handles this error.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>

ansibullbot · 2022-08-29T21:18:07Z

cc @jillr @s-hertel @tremble @whiter
click here for bot help

softwarefactory-project-zuul · 2022-08-29T22:33:24Z

Build failed.

tremble

I don't expect this PR to fix the issue reported, it'll just bump the exception to a later call.

The InvalidVpcID.NotFound exception is still likely to get thrown
a) By describe_vpc_classic_link_dns_support
b) (possibly) By describe_vpc_attribute

In my opinion it would be better to move the describe_vpc_classic_link and describe_vpc_classic_link_dns_support calls into the main loop (originally line 212).

We should then explicitly handle the InvalidVpcID.NotFound exceptions for all of the describe_ calls.

I'd also be tempted to pull the try/except blocks out into their own functions, to reduce the copy/paste a little. For example:

def describe_vpc_attribute(connection, module, vpc_id, attribute):
    error_message = "Unable to describe VPC attribute {0} on VPC {1}"
    try:
        return connection.describe_vpc_attribute(VpcId=vpc_id, Attribute=attribute, aws_retry=True)
    except is_boto3_error_code('InvalidVpcID.NotFound'):
        module.warn(error_message.format(attribute, vpc_id))
        return None
    except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
        module.fail_json_aws(e, msg=error_message.format(attribute, vpc_id))

You'll need to be a little more careful when processing the attributes, but it's probably worth it.

GomathiselviS · 2022-08-30T17:53:35Z

I don't expect this PR to fix the issue reported, it'll just bump the exception to a later call.

The InvalidVpcID.NotFound exception is still likely to get thrown a) By describe_vpc_classic_link_dns_support b) (possibly) By describe_vpc_attribute

In my opinion it would be better to move the describe_vpc_classic_link and describe_vpc_classic_link_dns_support calls into the main loop (originally line 212).

We should then explicitly handle the InvalidVpcID.NotFound exceptions for all of the describe_ calls.

I'd also be tempted to pull the try/except blocks out into their own functions, to reduce the copy/paste a little. For example:
def describe_vpc_attribute(connection, module, vpc_id, attribute):
    error_message = "Unable to describe VPC attribute {0} on VPC {1}"
    try:
        return connection.describe_vpc_attribute(VpcId=vpc_id, Attribute=attribute, aws_retry=True)
    except is_boto3_error_code('InvalidVpcID.NotFound'):
        module.warn(error_message.format(attribute, vpc_id))
        return None
    except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
        module.fail_json_aws(e, msg=error_message.format(attribute, vpc_id))
You'll need to be a little more careful when processing the attributes, but it's probably worth it.

A warning is thrown if the vpc is a shared vpc. Following is a sample return payload

[WARNING]: Unable to describe VPC attribute ClassicLinkEnabled on VPC vpc-03ad6a81c023b59fb
ok: [localhost] => {
    "changed": false,
    "invocation": {
        "module_args": {
            "aws_access_key": null,
            "aws_ca_bundle": null,
            "aws_config": null,
            "aws_secret_key": null,
            "debug_botocore_endpoint_logs": false,
            "ec2_url": null,
            "filters": {},
            "profile": null,
            "region": null,
            "security_token": null,
            "validate_certs": true,
            "vpc_ids": []
        }
    },
    "vpcs": [
        {
            "cidr_block": "172.31.0.0/16",
            "cidr_block_association_set": [
                {
                    "association_id": "vpc-cidr-assoc-03731e0529a8865fe",
                    "cidr_block": "172.31.0.0/16",
                    "cidr_block_state": {
                        "state": "associated"
                    }
                }
            ],
            "classic_link_dns_supported": false,
            "classic_link_enabled": false,
            "dhcp_options_id": "dopt-0e3763d36c420b1fe",
            "enable_dns_hostnames": true,
            "enable_dns_support": true,
            "id": "vpc-0c50cff2f20e950ab",
            "instance_tenancy": "default",
            "is_default": true,
            "owner_id": "212924601910",
            "state": "available",
            "tags": {},
            "vpc_id": "vpc-0c50cff2f20e950ab"
        },
        {
            "cidr_block": "10.0.0.0/16",
            "cidr_block_association_set": [
                {
                    "association_id": "vpc-cidr-assoc-067de6c6064e612dc",
                    "cidr_block": "10.0.0.0/16",
                    "cidr_block_state": {
                        "state": "associated"
                    }
                }
            ],
            "dhcp_options_id": "dopt-04083a54c58622e48",
            "enable_dns_hostnames": false,
            "enable_dns_support": true,
            "id": "vpc-03ad6a81c023b59fb",
            "instance_tenancy": "default",
            "is_default": false,
            "owner_id": "350064881214",
            "state": "available",
            "tags": {
                "Name": "sharedfromacc5"
            },
            "vpc_id": "vpc-03ad6a81c023b59fb"
        }
    ]
}

softwarefactory-project-zuul · 2022-08-30T19:55:17Z

Build failed.

GomathiselviS · 2022-08-30T20:39:45Z

recheck

softwarefactory-project-zuul · 2022-08-30T21:15:43Z

Build succeeded.

plugins/modules/ec2_vpc_net_info.py

softwarefactory-project-zuul · 2022-09-02T20:24:12Z

Build succeeded.

tremble

Minor tweak to changelog but otherwise lgtm

changelogs/fragments/984-ec2_vpc_net_info_shared_vpc.yml

github-actions · 2022-09-07T12:29:38Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-09-07T12:46:55Z

Build succeeded.

softwarefactory-project-zuul · 2022-09-07T13:06:35Z

Build succeeded (gate pipeline).

Various integration test fixes SUMMARY Updates the version of Python used by lambda in the lambda_alias, lambda_policy and aws_secret integration tests Updates the version of NodeJS used by the lambda in the lamba integration tests Adds a retry to the s3_bucket_notification tests, permissions are sometimes a little slow to update Cleans up Snapshots from rds_instance integration tests Disables broken WAFv2 integration test (ansible-collections#985) Fixes: ansible-collections#976 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret lambda lambda_alias lambda_policy rds_policy s3_bucket_notification wafv2 ADDITIONAL INFORMATION Amazon appear to have dropped support for creating Python2.7 lambdas: botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions. Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c5e4640

ec2_vpc_net_info: fix keyerror SUMMARY Introduced in #984 since amazon.aws 5.0.0 KeyError: 'ClassicLinkDnsSupported' ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_net_info ADDITIONAL INFORMATION --- - hosts: localhost tasks: - name: Get VPC Information ec2_vpc_net_info: region: eu-central-1 register: vpc - debug: var: vpc results in ansible-playbook [core 2.12.5] config file = /home/m/git/lekker/iac/ansible.cfg configured module search path = ['/home/m/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /home/m/.local/lib/python3.10/site-packages/ansible ansible collection location = /home/m/.ansible/collections:/usr/share/ansible/collections executable location = /home/m/.local/bin/ansible-playbook python version = 3.10.6 (main, Aug 10 2022, 11:40:04) [GCC 11.3.0] jinja version = 3.1.2 libyaml = True Using /home/m/git/lekker/iac/ansible.cfg as config file host_list declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user script declined parsing /etc/ansible/hosts as it did not pass its verify_file() method auto declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user yaml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user ini declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user toml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Skipping callback 'default', as we already have a stdout callback. Skipping callback 'minimal', as we already have a stdout callback. Skipping callback 'oneline', as we already have a stdout callback. PLAYBOOK: dev003.yml *********************************************************** 1 plays in dev003.yml PLAY [localhost] *************************************************************** TASK [Gathering Facts] ********************************************************* task path: /home/m/git/lekker/iac/dev003.yml:2 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" && echo ansible-tmp-1664956131.9332027-127698-125869016159264="` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" ) && sleep 0' Using module file /home/m/.local/lib/python3.10/site-packages/ansible/modules/setup.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmpyv6re_ml TO /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ > /dev/null 2>&1 && sleep 0' ok: [localhost] META: ran handlers TASK [Get VPC Information] ***************************************************** task path: /home/m/git/lekker/iac/dev003.yml:5 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" && echo ansible-tmp-1664956133.024292-127805-105124013383109="` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" ) && sleep 0' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Using module file /home/m/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmphfs01m94 TO /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ > /dev/null 2>&1 && sleep 0' The full traceback is: Traceback (most recent call last): File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 107, in <module> _ansiballz_main() File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 47, in invoke_module runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path), File "/usr/lib/python3.10/runpy.py", line 224, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File "/usr/lib/python3.10/runpy.py", line 86, in _run_code exec(code, run_globals) File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 272, in <module> File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 268, in main File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 215, in describe_vpcs KeyError: 'ClassicLinkDnsSupported' fatal: [localhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 107, in <module>\n _ansiballz_main()\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 99, in _ansiballz_main\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 47, in invoke_module\n runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path),\n File \"/usr/lib/python3.10/runpy.py\", line 224, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 272, in <module>\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 268, in main\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 215, in describe_vpcs\nKeyError: 'ClassicLinkDnsSupported'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } PLAY RECAP ********************************************************************* localhost : ok=1 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0 Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>

ec2_vpc_net_info: fix keyerror SUMMARY Introduced in #984 since amazon.aws 5.0.0 KeyError: 'ClassicLinkDnsSupported' ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_net_info ADDITIONAL INFORMATION --- - hosts: localhost tasks: - name: Get VPC Information ec2_vpc_net_info: region: eu-central-1 register: vpc - debug: var: vpc results in ansible-playbook [core 2.12.5] config file = /home/m/git/lekker/iac/ansible.cfg configured module search path = ['/home/m/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /home/m/.local/lib/python3.10/site-packages/ansible ansible collection location = /home/m/.ansible/collections:/usr/share/ansible/collections executable location = /home/m/.local/bin/ansible-playbook python version = 3.10.6 (main, Aug 10 2022, 11:40:04) [GCC 11.3.0] jinja version = 3.1.2 libyaml = True Using /home/m/git/lekker/iac/ansible.cfg as config file host_list declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user script declined parsing /etc/ansible/hosts as it did not pass its verify_file() method auto declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user yaml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user ini declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user toml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Skipping callback 'default', as we already have a stdout callback. Skipping callback 'minimal', as we already have a stdout callback. Skipping callback 'oneline', as we already have a stdout callback. PLAYBOOK: dev003.yml *********************************************************** 1 plays in dev003.yml PLAY [localhost] *************************************************************** TASK [Gathering Facts] ********************************************************* task path: /home/m/git/lekker/iac/dev003.yml:2 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" && echo ansible-tmp-1664956131.9332027-127698-125869016159264="` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" ) && sleep 0' Using module file /home/m/.local/lib/python3.10/site-packages/ansible/modules/setup.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmpyv6re_ml TO /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ > /dev/null 2>&1 && sleep 0' ok: [localhost] META: ran handlers TASK [Get VPC Information] ***************************************************** task path: /home/m/git/lekker/iac/dev003.yml:5 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" && echo ansible-tmp-1664956133.024292-127805-105124013383109="` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" ) && sleep 0' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Using module file /home/m/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmphfs01m94 TO /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ > /dev/null 2>&1 && sleep 0' The full traceback is: Traceback (most recent call last): File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 107, in <module> _ansiballz_main() File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 47, in invoke_module runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path), File "/usr/lib/python3.10/runpy.py", line 224, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File "/usr/lib/python3.10/runpy.py", line 86, in _run_code exec(code, run_globals) File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 272, in <module> File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 268, in main File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 215, in describe_vpcs KeyError: 'ClassicLinkDnsSupported' fatal: [localhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 107, in <module>\n _ansiballz_main()\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 99, in _ansiballz_main\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 47, in invoke_module\n runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path),\n File \"/usr/lib/python3.10/runpy.py\", line 224, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 272, in <module>\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 268, in main\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 215, in describe_vpcs\nKeyError: 'ClassicLinkDnsSupported'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } PLAY RECAP ********************************************************************* localhost : ok=1 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0 Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 1573f17)

SUMMARY Introduced in #984 since amazon.aws 5.0.0 KeyError: 'ClassicLinkDnsSupported' ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_net_info ADDITIONAL INFORMATION --- - hosts: localhost tasks: - name: Get VPC Information ec2_vpc_net_info: region: eu-central-1 register: vpc - debug: var: vpc results in ansible-playbook [core 2.12.5] config file = /home/m/git/lekker/iac/ansible.cfg configured module search path = ['/home/m/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /home/m/.local/lib/python3.10/site-packages/ansible ansible collection location = /home/m/.ansible/collections:/usr/share/ansible/collections executable location = /home/m/.local/bin/ansible-playbook python version = 3.10.6 (main, Aug 10 2022, 11:40:04) [GCC 11.3.0] jinja version = 3.1.2 libyaml = True Using /home/m/git/lekker/iac/ansible.cfg as config file host_list declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user script declined parsing /etc/ansible/hosts as it did not pass its verify_file() method auto declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user yaml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user ini declined parsing /etc/ansible/hosts as it did not pass its verify_file() method Skipping due to inventory source not existing or not being readable by the current user toml declined parsing /etc/ansible/hosts as it did not pass its verify_file() method [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Skipping callback 'default', as we already have a stdout callback. Skipping callback 'minimal', as we already have a stdout callback. Skipping callback 'oneline', as we already have a stdout callback. PLAYBOOK: dev003.yml *********************************************************** 1 plays in dev003.yml PLAY [localhost] *************************************************************** TASK [Gathering Facts] ********************************************************* task path: /home/m/git/lekker/iac/dev003.yml:2 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" && echo ansible-tmp-1664956131.9332027-127698-125869016159264="` echo /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264 `" ) && sleep 0' Using module file /home/m/.local/lib/python3.10/site-packages/ansible/modules/setup.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmpyv6re_ml TO /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/AnsiballZ_setup.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956131.9332027-127698-125869016159264/ > /dev/null 2>&1 && sleep 0' ok: [localhost] META: ran handlers TASK [Get VPC Information] ***************************************************** task path: /home/m/git/lekker/iac/dev003.yml:5 <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m <127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0' <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" && echo ansible-tmp-1664956133.024292-127805-105124013383109="` echo /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109 `" ) && sleep 0' redirecting (type: modules) ansible.builtin.ec2_vpc_net_info to amazon.aws.ec2_vpc_net_info Using module file /home/m/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py <127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-127691_siearhm/tmphfs01m94 TO /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/ > /dev/null 2>&1 && sleep 0' The full traceback is: Traceback (most recent call last): File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 107, in <module> _ansiballz_main() File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File "/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py", line 47, in invoke_module runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path), File "/usr/lib/python3.10/runpy.py", line 224, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File "/usr/lib/python3.10/runpy.py", line 86, in _run_code exec(code, run_globals) File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 272, in <module> File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 268, in main File "/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py", line 215, in describe_vpcs KeyError: 'ClassicLinkDnsSupported' fatal: [localhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 107, in <module>\n _ansiballz_main()\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 99, in _ansiballz_main\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n File \"/home/m/.ansible/tmp/ansible-tmp-1664956133.024292-127805-105124013383109/AnsiballZ_ec2_vpc_net_info.py\", line 47, in invoke_module\n runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.ec2_vpc_net_info', _modlib_path=modlib_path),\n File \"/usr/lib/python3.10/runpy.py\", line 224, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 272, in <module>\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 268, in main\n File \"/tmp/ansible_ec2_vpc_net_info_payload_oi896utp/ansible_ec2_vpc_net_info_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_net_info.py\", line 215, in describe_vpcs\nKeyError: 'ClassicLinkDnsSupported'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } PLAY RECAP ********************************************************************* localhost : ok=1 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0 Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 1573f17) Co-authored-by: Markus Bergholz <git@osuv.de>

Various integration test fixes SUMMARY Updates the version of Python used by lambda in the lambda_alias, lambda_policy and aws_secret integration tests Updates the version of NodeJS used by the lambda in the lamba integration tests Adds a retry to the s3_bucket_notification tests, permissions are sometimes a little slow to update Cleans up Snapshots from rds_instance integration tests Disables broken WAFv2 integration test (ansible-collections#985) Fixes: ansible-collections#976 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret lambda lambda_alias lambda_policy rds_policy s3_bucket_notification wafv2 ADDITIONAL INFORMATION Amazon appear to have dropped support for creating Python2.7 lambdas: botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions. Reviewed-by: Alina Buzachis <None>

Handle absence of classic link support for shared VPCs

5f8f84c

Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>

ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Aug 29, 2022

Added changelog

5efae79

tremble reviewed Aug 30, 2022

View reviewed changes

refactor

57a2510

GomathiselviS requested a review from tremble August 30, 2022 17:54

Fix pep8 failures

92d9e5f

GomathiselviS requested a review from jillr August 31, 2022 13:00

tremble reviewed Sep 1, 2022

View reviewed changes

plugins/modules/ec2_vpc_net_info.py Outdated Show resolved Hide resolved

Handle variables with empty value

a94d487

GomathiselviS requested a review from tremble September 2, 2022 20:07

goneri removed the needs_triage label Sep 6, 2022

tremble approved these changes Sep 7, 2022

View reviewed changes

changelogs/fragments/984-ec2_vpc_net_info_shared_vpc.yml Outdated Show resolved Hide resolved

Update changelog

adfb007

tremble reviewed Sep 7, 2022

View reviewed changes

changelogs/fragments/984-ec2_vpc_net_info_shared_vpc.yml Outdated Show resolved Hide resolved

changelog

e15c688

GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label Sep 7, 2022

softwarefactory-project-zuul bot merged commit 14a4507 into ansible-collections:main Sep 7, 2022

renovate bot mentioned this pull request Oct 4, 2022

Update dependency amazon.aws to v5 - autoclosed platan/metrics-shields-io-config#109

Closed

1 task

markuman mentioned this pull request Oct 5, 2022

ec2_vpc_net_info: fix keyerror #1109

Merged

patchback bot mentioned this pull request Oct 5, 2022

[PR #1109/1573f17d backport][stable-5] ec2_vpc_net_info: fix keyerror #1113

Merged

renovate bot mentioned this pull request Oct 27, 2022

Update dependency amazon.aws to v5 - autoclosed jkroepke/homelab#27

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle absence of classic link support for shared VPCs #984

Handle absence of classic link support for shared VPCs #984

GomathiselviS commented Aug 29, 2022 •

edited

Loading

ansibullbot commented Aug 29, 2022

softwarefactory-project-zuul bot commented Aug 29, 2022

tremble left a comment

GomathiselviS commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

GomathiselviS commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

softwarefactory-project-zuul bot commented Sep 2, 2022

tremble left a comment

github-actions bot commented Sep 7, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Sep 7, 2022

softwarefactory-project-zuul bot commented Sep 7, 2022

Handle absence of classic link support for shared VPCs #984

Handle absence of classic link support for shared VPCs #984

Conversation

GomathiselviS commented Aug 29, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Aug 29, 2022

softwarefactory-project-zuul bot commented Aug 29, 2022

tremble left a comment

Choose a reason for hiding this comment

GomathiselviS commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

GomathiselviS commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

softwarefactory-project-zuul bot commented Sep 2, 2022

tremble left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 7, 2022 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Sep 7, 2022

softwarefactory-project-zuul bot commented Sep 7, 2022

GomathiselviS commented Aug 29, 2022 •

edited

Loading

github-actions bot commented Sep 7, 2022 •

edited

Loading