feat: Configuration validation. fix #518 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
reviewed
Feb 22, 2024
|
LGTM! It'd be nice if you could add your rationale to the task itself so people who read the code will get an understanding why it is the way it is. |
bastienwirtz
force-pushed
the
ansible-config-validation
branch
from
213fe4d
to
8f8948c
Compare
|
@rndmh3ro @nre-ableton Updated ! |
rndmh3ro
approved these changes
Feb 22, 2024
isakrubin
added a commit
to car-info/ansible-consul
that referenced
this pull request
Jun 10, 2024
* upstream/master: Remove deprecated molecule/centos-stream-8 Fix rolling restart by waiting for consul leave and after restart Update molecule.yml --- (ansible-collections#597) Bump idna from 3.3 to 3.7 in the pip group across 1 directory (ansible-collections#596) Fix CI badge in README (ansible-collections#595) Fix ubuntu 22.04 molecule test to actually run on 22.04 (ansible-collections#594) feat: Configuration validation. fix ansible-collections#518 (ansible-collections#592) Fix error when creating gossip key (ansible-collections#558) adding become to service restarts (ansible-collections#571) Bump the pip group across 1 directories with 1 update (ansible-collections#590)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following discussion on #565, this patch implement the validation during install / update only
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
config tasks
ADDITIONAL INFORMATION
All configuration files must be given to the validate command at once (partial conf might raise some issue regarding missing some required items), so it's not possible to use the
validatearg og theansibvle.builtin.copymodule used to template the config (cc @rndmh3ro).