Fix: sysctl integration test - virtualization type #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I can tell the tests are being run. The latest build on main: https://dev.azure.com/ansible/ansible.posix/_build/results?buildId=20594&view=logs&j=a9e0bcaa-f9fa-54f9-1e7a-69855170566b&t=a3d86cda-daaa-54cd-38ff-e247a2c0bdcd&l=1268. Are you seeing otherwise? |
Yes, I'm seeing skipped as virtualization_type is being shown "container" while running the tests with --docker |
Akasurde
force-pushed
the
fix-integration-test-sysctl
branch
from
76de604
to
244c9b2
Compare
gravesm
approved these changes
Aug 4, 2021
Akasurde
added
the
gate
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
1 task
1 task
This was referenced Aug 19, 2022
This was referenced Sep 14, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
sysctl integration tests inside docker are being skipped as the check ansible_facts.virtualization_type == 'docker' fails.
On Debugging, ansible_facts.virtualization_type is being returned as "container".
ISSUE TYPE
COMPONENT NAME
sysctl
ADDITIONAL INFORMATION
Ansible Version
Docker Version
OS
Actual Results
Likely this code is related: https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/virtual/linux.py#L113