Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of service_endpoints configuration #309

Conversation

maartendekeizer
Copy link
Contributor

SUMMARY

Fixes #141

Add missing example to documentation for service_endpoints.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_subnet

ADDITIONAL INFORMATION

n/a

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 3, 2020

@maartendekeizer Thank you for submitting this PR. I don't think it is necessary to add this case, because tests/integration/targets/azure_rm_subnet/tasks/main.yml has already added related cases, thank you!

@Fred-sun Fred-sun added the work in In trying to solve, or in working with contributors label Nov 3, 2020
@maartendekeizer
Copy link
Contributor Author

@Fred-sun Thanks for your reply. As engineer I don't want to dive-in to test files of module I use to see examples on how I can use a module. I ran in the same situation as the ts of #141 and was happy that I found that issue. Also the locations options was not very clear the first time. That is why I think we need this in the documentation.

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 4, 2020

@maartendekeizer We need to discuss whether we need to do this, because if we put all the required Cases in the document, the module files will become a lot. Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority and removed work in In trying to solve, or in working with contributors labels Nov 5, 2020
@haiyuazhang haiyuazhang merged commit 0f326ba into ansible-collections:dev Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_subnet module generating error when using the service_endpoints parameter
3 participants