Fixed issue #232 Added Volume mount support for container instances #338

aparna-patil · 2020-11-26T14:06:12Z

SUMMARY

This pull request adds support for mounting volumes in container instance. With this feature, following types of Volumes can be mounted :

Empty directory Volume
Secret Volume
Git Repo Volume
Azure File Share Volume

Fixes #232

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

azure_rm_containerinstance
azure_rm_containerinstance_info

ADDITIONAL INFORMATION

Reference : https://docs.microsoft.com/en-us/rest/api/container-instances/containergroups/createorupdate#volume

aparna-patil · 2020-11-26T14:31:07Z

Hi @Fred-sun
Could you please help review this PR? As part of local sanity testing, I was getting some documentation errors, so tried to correct documentation as well through this PR. Kindly let me know if that's acceptable.
Thanks for your help!

Fred-sun · 2020-11-30T10:02:43Z

ERROR: tests/sanity/ignore-2.10.txt:48:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:49:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:50:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:51:1: A100: Ignoring 'doc-required-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:55:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary

Fred-sun · 2020-11-30T10:02:24Z

tests/integration/targets/azure_rm_containerinstance/tasks/main.yml

+        image: httpd
+        memory: 1.5
+        volume_mounts:
+          - name: filesharevolume


How did this account name ? It can't access?

Hi @Fred-sun Apologies, I didn't get your question. Could you please elaborate your question so that I can understand it better and take the action? Thank you!
FYI - I am referring to this document for Azure file volumes - https://docs.microsoft.com/en-us/azure/container-instances/container-instances-volume-azure-files

On line no. 165 volumes specification is initialized and there we have specified three parameters (storage_account_name, share_name and storage_account_key) which are needed in order to mount azure file volume on container instance

Hi @Fred-sun Could you please guide me here to understand what changes are required for line no. 160? Thanks for your help!

aparna-patil · 2020-12-03T08:20:50Z

ERROR: tests/sanity/ignore-2.10.txt:48:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:49:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:50:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:51:1: A100: Ignoring 'doc-required-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:55:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary

Hi @Fred-sun , Done - updated this file. Thank you!

aparna-patil · 2021-02-26T13:09:19Z

Hi @Fred-sun , Could you please help provide your feedback on this PR ? Kindly let me know if any more changes are required ? Will incorporate those changes.
Since, currently there is no support to mount any type of volume in container instances we are using AZ command line option to do this task. Thanks for your help!

aparna-patil · 2021-03-01T13:15:19Z

Hello @Fred-sun , Could you please help review this PR whenever you get some time? Thank you

tests/integration/targets/azure_rm_containerinstance/tasks/main.yml

Fred-sun · 2021-03-10T02:48:48Z

@aparna-patil Please!

ERROR: tests/sanity/ignore-2.9.txt:15:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.9.txt:16:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.9.txt:17:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:50:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:51:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:52:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:53:1: A100: Ignoring 'doc-required-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:57:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary

…ub.com/aparna-patil/azure into 232-volumeSupportForContainerInstances

aparna-patil · 2021-03-12T07:50:53Z

@aparna-patil Please!

ERROR: tests/sanity/ignore-2.9.txt:15:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.9.txt:16:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.9.txt:17:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:50:1: A100: Ignoring 'doc-type-does-not-match-spec' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:51:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:52:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:53:1: A100: Ignoring 'doc-required-mismatch' on 'plugins/modules/azure_rm_containerinstance.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:57:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_containerinstance_info.py' is unnecessary

Hi @Fred-sun , Updated sanity check files. Thank you. Could you please help review the PR again post changes?

Ompragash · 2021-04-06T13:37:37Z

@Fred-sun Could you kindly check on this PR?

Fred-sun · 2021-04-06T14:25:32Z

@Fred-sun Could you kindly check on this PR?

@Ompragash Okay! I'm working! Thank you very much!

aparna-patil · 2021-04-11T06:19:54Z

Hi @Fred-sun Could you please help me review and push these changes? This feature is stuck from long time, please help me...

aparna-patil · 2021-06-22T11:43:59Z

Hi @Fred-sun resolved merge conflicts and corrected tests/integration/targets/azure_rm_containerinstance/tasks/main.yml file.

Sharing the local integration test results below. Could you please help review once again? Thank you!

root@my-vm:~/ansible# ansible-test integration azure_rm_containerinstance --allow-destructive -vvv
RLIMIT_NOFILE: (1024, 1048576)
MAXFD: -1
>>> Container Database
{}
Run command: /usr/bin/python /root/ansible/test/lib/ansible_test/_data/yamlcheck.py
Working directory: /root/ansible
Program found: /usr/bin/python
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Run command: /usr/bin/python /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Run command: /usr/bin/python3 /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python3
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Run command: /usr/bin/python3.8 /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python3.8
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
>>> Environment Description
{
    "known_hosts_hash": "b0709d04e0374eb987a2282fdbcbc8b6349e418038aa0c7972062d8eac2998c9",
    "pip_interpreters": {
        "": "#!/usr/bin/python3",
        "3": "#!/usr/bin/python3",
        "3.8": "#!/usr/bin/python3"
    },
    "pip_paths": {
        "": "/usr/local/bin/pip",
        "2": null,
        "2.6": null,
        "2.7": null,
        "3": "/usr/local/bin/pip3",
        "3.5": null,
        "3.6": null,
        "3.7": null,
        "3.8": "/usr/local/bin/pip3.8",
        "3.9": null
    },
    "program_versions": {
        "": [
            "3.8.2 (default, Jul 16 2020, 14:00:26)",
            "[GCC 9.3.0]",
            "pip 21.1.1 from /usr/local/lib/python3.8/dist-packages/pip-21.1.1-py3.8.egg/pip"
        ],
        "3": [
            "3.8.2 (default, Jul 16 2020, 14:00:26)",
            "[GCC 9.3.0]",
            "pip 21.1.1 from /usr/local/lib/python3.8/dist-packages/pip-21.1.1-py3.8.egg/pip"
        ],
        "3.8": [
            "3.8.2 (default, Jul 16 2020, 14:00:26)",
            "[GCC 9.3.0]",
            "pip 21.1.1 from /usr/local/lib/python3.8/dist-packages/pip-21.1.1-py3.8.egg/pip"
        ]
    },
    "python_paths": {
        "": "/usr/bin/python",
        "2": null,
        "2.6": null,
        "2.7": null,
        "3": "/usr/bin/python3",
        "3.5": null,
        "3.6": null,
        "3.7": null,
        "3.8": "/usr/bin/python3.8",
        "3.9": null
    },
    "warnings": []
}
Running azure_rm_containerinstance integration test role
Preparing temporary directory: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ
Copying test/integration/targets/azure_rm_containerinstance/ to /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/
Copying /root/ansible/test/integration/integration_config.yml to /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/integration_config.yml
Copying /root/ansible/test/lib/ansible_test/_data/ansible.cfg to /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/integration.cfg
Copying /root/ansible/test/lib/ansible_test/_data/inventory to /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory
>>> Playbook: azure_rm_containerinstance-n1nw0lp0.yml
[
    {
        "gather_facts": true,
        "hosts": "testhost",
        "roles": [
            "azure_rm_containerinstance"
        ],
        "vars": {
            "output_dir": "/root/ansible/test/results/.tmp/output_dir"
        },
        "vars_files": [
            "integration_config.yml"
        ]
    }
]
Injecting "/tmp/python-410n1wz8-ansible/python" as a execv wrapper for the "/usr/bin/python" interpreter.
Run command: ansible-playbook azure_rm_containerinstance-n1nw0lp0.yml -i inventory -vvv
Working directory: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration
Program found: /root/ansible/test/lib/ansible_test/_data/injector/ansible-playbook
ANSIBLE_CACHE_PLUGINS=/root/ansible/test/support/integration/plugins/cache
ANSIBLE_CALLBACKS_ENABLED=junit
ANSIBLE_CONFIG=/root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/integration.cfg
ANSIBLE_CONTROLLER_PYTHON_WARNING=false
ANSIBLE_DEPRECATION_WARNINGS=false
ANSIBLE_DEVEL_WARNING=false
ANSIBLE_FILTER_PLUGINS=/root/ansible/test/support/integration/plugins/filter
ANSIBLE_FORCE_COLOR=true
ANSIBLE_FORCE_HANDLERS=true
ANSIBLE_HOST_KEY_CHECKING=false
ANSIBLE_HOST_PATTERN_MISMATCH=error
ANSIBLE_INVENTORY=/dev/null
ANSIBLE_INVENTORY_PLUGINS=/root/ansible/test/support/integration/plugins/inventory
ANSIBLE_LIBRARY=/root/ansible/test/support/integration/plugins/modules
ANSIBLE_LOOKUP_PLUGINS=/root/ansible/test/support/integration/plugins/lookup
ANSIBLE_MODULE_UTILS=/root/ansible/test/support/integration/plugins/module_utils
ANSIBLE_PLAYBOOK_DIR=/root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration
ANSIBLE_PYTHON_INTERPRETER=/set/ansible_python_interpreter/in/inventory
ANSIBLE_PYTHON_MODULE_RLIMIT_NOFILE=1024
ANSIBLE_RETRY_FILES_ENABLED=false
ANSIBLE_ROLES_PATH=/root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets
ANSIBLE_TEST_CI=
ANSIBLE_TEST_COVERAGE=
ANSIBLE_TEST_PYTHON_INTERPRETER=/usr/bin/python
ANSIBLE_TEST_PYTHON_VERSION=3.8
ANSIBLE_WORKER_SHUTDOWN_POLL_COUNT=100
ANSIBLE_WORKER_SHUTDOWN_POLL_DELAY=0.1
HOME=/root
INVENTORY_PATH=/root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory
JUNIT_OUTPUT_DIR=/root/ansible/test/results/junit
LC_ALL=en_US.UTF-8
OUTPUT_DIR=/root/ansible/test/results/.tmp/output_dir
PAGER=/bin/cat
PATH=/tmp/python-410n1wz8-ansible:/root/ansible/test/lib/ansible_test/_data/injector:/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
PYTHONPATH=/root/ansible/lib
ansible-playbook [core 2.12.0.dev0]  (devel 9ba6cf9a72) last updated 2021/04/19 16:15:31 (GMT +550)
  config file = /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/integration.cfg
  configured module search path = ['/root/ansible/test/support/integration/plugins/modules']
  ansible python module location = /root/ansible/lib/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /root/ansible/bin/ansible-playbook
  python version = 3.8.2 (default, Jul 16 2020, 14:00:26) [GCC 9.3.0]
  jinja version = 2.10.1
  libyaml = True
Using /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/integration.cfg as config file
host_list declined parsing /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory as it did not pass its verify_file() method
script declined parsing /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory as it did not pass its verify_file() method
auto declined parsing /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory as it did not pass its verify_file() method
Parsed /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/inventory inventory source with ini plugin
Read vars_file 'integration_config.yml'
Skipping callback 'default', as we already have a stdout callback.
[WARNING]: The `junit_xml` python module is not installed. Disabling the `junit` callback plugin.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.

PLAYBOOK: azure_rm_containerinstance-n1nw0lp0.yml *********************************************************************************************************************************************************
1 plays in azure_rm_containerinstance-n1nw0lp0.yml
Read vars_file 'integration_config.yml'
Read vars_file 'integration_config.yml'
Read vars_file 'integration_config.yml'

PLAY [testhost] *******************************************************************************************************************************************************************************************
Read vars_file 'integration_config.yml'

TASK [Gathering Facts] ************************************************************************************************************************************************************************************
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'echo ~root && sleep 0'
<testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446 `" && echo ansible-tmp-1624360381.303341-4465-271781278661446="` echo /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446 `" ) && sleep 0'
Using module file /root/ansible/lib/ansible/modules/setup.py
<testhost> PUT /root/.ansible/tmp/ansible-local-4460xwm5fb10/tmpnkqwdk4e TO /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446/AnsiballZ_setup.py
<testhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446/ /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446/AnsiballZ_setup.py && sleep 0'
<testhost> EXEC /bin/sh -c '/usr/bin/python /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446/AnsiballZ_setup.py && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1624360381.303341-4465-271781278661446/ > /dev/null 2>&1 && sleep 0'
ok: [testhost]
Read vars_file 'integration_config.yml'
META: ran handlers
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : Create sample container instance with volume] **************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:19
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'echo ~root && sleep 0'
<testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033 `" && echo ansible-tmp-1624360383.2760081-4530-183241157075033="` echo /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033 `" ) && sleep 0'
Using module file /root/ansible/lib/ansible/modules/azure_rm_containerinstance.py
<testhost> PUT /root/.ansible/tmp/ansible-local-4460xwm5fb10/tmpb45bjyzz TO /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033/AnsiballZ_azure_rm_containerinstance.py
<testhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033/ /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033/AnsiballZ_azure_rm_containerinstance.py && sleep 0'
<testhost> EXEC /bin/sh -c '/usr/bin/python /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033/AnsiballZ_azure_rm_containerinstance.py && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1624360383.2760081-4530-183241157075033/ > /dev/null 2>&1 && sleep 0'
[WARNING]: Installed azure-mgmt-containerinstance client version is 1.4.0. The expected version is 0.4.0. Try `pip install ansible[azure]`
changed: [testhost] => {
    "changed": true,
    "id": "/subscriptions/7b1b46f1-e266-404e-96b4-8738a385c254/resourceGroups/MyAzureResourceGroup/providers/Microsoft.ContainerInstance/containerGroups/acic45a0c9",
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": null,
            "cloud_environment": "AzureCloud",
            "containers": [
                {
                    "commands": null,
                    "cpu": 1.0,
                    "environment_variables": null,
                    "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
                    "memory": 1.5,
                    "name": "mycontainer1",
                    "ports": [
                        80,
                        81
                    ],
                    "volume_mounts": [
                        {
                            "mount_path": "/data/files",
                            "name": "my-filesharevolume",
                            "read_only": null
                        }
                    ]
                }
            ],
            "dns_name_label": null,
            "force_update": false,
            "ip_address": "public",
            "location": "eastus",
            "name": "acic45a0c9",
            "os_type": "linux",
            "password": null,
            "ports": [
                80
            ],
            "profile": null,
            "registry_login_server": null,
            "registry_password": null,
            "registry_username": null,
            "resource_group": "MyAzureResourceGroup",
            "restart_policy": null,
            "secret": null,
            "state": "present",
            "subscription_id": null,
            "tags": null,
            "tenant": null,
            "volumes": [
                {
                    "azure_file": {
                        "read_only": null,
                        "share_name": "my-fileshare",
                        "storage_account_key": "x3xaeDCHZxk3Jnm3/lHX9xaNCCzU4hwXN9OMw2GjBRva3ybVzQ+uc2TgAOcQzi/IV6OzHzt/5SM0JmU1xdjA6Q==",
                        "storage_account_name": "mystorageaccountap"
                    },
                    "empty_dir": null,
                    "git_repo": null,
                    "name": "my-filesharevolume",
                    "secret": null
                }
            ]
        }
    },
    "ip_address": "20.84.34.78",
    "provisioning_state": "Succeeded",
    "state": {}
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : debug] *****************************************************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:46
ok: [testhost] => {
    "output": {
        "changed": true,
        "failed": false,
        "id": "/subscriptions/7b1b46f1-e266-404e-96b4-8738a385c254/resourceGroups/MyAzureResourceGroup/providers/Microsoft.ContainerInstance/containerGroups/acic45a0c9",
        "ip_address": "20.84.34.78",
        "provisioning_state": "Succeeded",
        "state": {},
        "warnings": [
            "Installed azure-mgmt-containerinstance client version is 1.4.0. The expected version is 0.4.0. Try `pip install ansible[azure]`"
        ]
    }
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : Assert the container instance is well created] *************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:49
ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : Gather facts for Container Instance] ***********************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:55
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'echo ~root && sleep 0'
<testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264 `" && echo ansible-tmp-1624360425.0305986-4562-96732305240264="` echo /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264 `" ) && sleep 0'
Using module file /root/ansible/lib/ansible/modules/azure_rm_containerinstance_info.py
<testhost> PUT /root/.ansible/tmp/ansible-local-4460xwm5fb10/tmpupv9dt_6 TO /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264/AnsiballZ_azure_rm_containerinstance_info.py
<testhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264/ /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264/AnsiballZ_azure_rm_containerinstance_info.py && sleep 0'
<testhost> EXEC /bin/sh -c '/usr/bin/python /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264/AnsiballZ_azure_rm_containerinstance_info.py && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1624360425.0305986-4562-96732305240264/ > /dev/null 2>&1 && sleep 0'
ok: [testhost] => {
    "changed": false,
    "containerinstances": [
        {
            "containers": [
                {
                    "commands": null,
                    "cpu": 1.0,
                    "environment_variables": [],
                    "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
                    "memory": 1.5,
                    "name": "mycontainer1",
                    "ports": [
                        80,
                        81
                    ],
                    "volume_mounts": [
                        {
                            "mount_path": "/data/files",
                            "name": "my-filesharevolume"
                        }
                    ]
                }
            ],
            "dns_name_label": null,
            "id": "/subscriptions/7b1b46f1-e266-404e-96b4-8738a385c254/resourceGroups/MyAzureResourceGroup/providers/Microsoft.ContainerInstance/containerGroups/acic45a0c9",
            "ip_address": "20.84.34.78",
            "location": "eastus",
            "name": "acic45a0c9",
            "os_type": "Linux",
            "ports": [
                80,
                81
            ],
            "resource_group": "MyAzureResourceGroup",
            "restart_policy": null,
            "tags": null,
            "volumes": [
                {
                    "azure_file": {
                        "share_name": "my-fileshare",
                        "storage_account_name": "mystorageaccountap"
                    },
                    "name": "my-filesharevolume"
                }
            ]
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": null,
            "cloud_environment": "AzureCloud",
            "name": "acic45a0c9",
            "password": null,
            "profile": null,
            "resource_group": "MyAzureResourceGroup",
            "secret": null,
            "subscription_id": null,
            "tags": null,
            "tenant": null
        }
    }
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : debug] *****************************************************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:61
ok: [testhost] => {
    "output": {
        "changed": false,
        "containerinstances": [
            {
                "containers": [
                    {
                        "commands": null,
                        "cpu": 1.0,
                        "environment_variables": [],
                        "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
                        "memory": 1.5,
                        "name": "mycontainer1",
                        "ports": [
                            80,
                            81
                        ],
                        "volume_mounts": [
                            {
                                "mount_path": "/data/files",
                                "name": "my-filesharevolume"
                            }
                        ]
                    }
                ],
                "dns_name_label": null,
                "id": "/subscriptions/7b1b46f1-e266-404e-96b4-8738a385c254/resourceGroups/MyAzureResourceGroup/providers/Microsoft.ContainerInstance/containerGroups/acic45a0c9",
                "ip_address": "20.84.34.78",
                "location": "eastus",
                "name": "acic45a0c9",
                "os_type": "Linux",
                "ports": [
                    80,
                    81
                ],
                "resource_group": "MyAzureResourceGroup",
                "restart_policy": null,
                "tags": null,
                "volumes": [
                    {
                        "azure_file": {
                            "share_name": "my-fileshare",
                            "storage_account_name": "mystorageaccountap"
                        },
                        "name": "my-filesharevolume"
                    }
                ]
            }
        ],
        "failed": false,
        "warnings": [
            "Installed azure-mgmt-containerinstance client version is 1.4.0. The expected version is 0.4.0. Try `pip install ansible[azure]`"
        ]
    }
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : Assert that facts are returned] ****************************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:64
ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"
}
Read vars_file 'integration_config.yml'

TASK [azure_rm_containerinstance : Remove container instance] *********************************************************************************************************************************************
task path: /root/ansible/test/results/.tmp/integration/azure_rm_containerinstance-gv27ufvs-ÅÑŚÌβŁÈ/test/integration/targets/azure_rm_containerinstance/tasks/main.yml:80
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'echo ~root && sleep 0'
<testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797 `" && echo ansible-tmp-1624360430.384739-4595-237838525950797="` echo /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797 `" ) && sleep 0'
Using module file /root/ansible/lib/ansible/modules/azure_rm_containerinstance.py
<testhost> PUT /root/.ansible/tmp/ansible-local-4460xwm5fb10/tmpkx861qdc TO /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797/AnsiballZ_azure_rm_containerinstance.py
<testhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797/ /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797/AnsiballZ_azure_rm_containerinstance.py && sleep 0'
<testhost> EXEC /bin/sh -c '/usr/bin/python /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797/AnsiballZ_azure_rm_containerinstance.py && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1624360430.384739-4595-237838525950797/ > /dev/null 2>&1 && sleep 0'
changed: [testhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": null,
            "cloud_environment": "AzureCloud",
            "containers": [
                {
                    "commands": null,
                    "cpu": 1.0,
                    "environment_variables": null,
                    "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
                    "memory": 1.5,
                    "name": "mycontainer1",
                    "ports": [
                        80,
                        81
                    ],
                    "volume_mounts": [
                        {
                            "mount_path": "/data/files",
                            "name": "my-filesharevolume",
                            "read_only": null
                        }
                    ]
                }
            ],
            "dns_name_label": null,
            "force_update": false,
            "ip_address": "public",
            "location": "eastus",
            "name": "acic45a0c9",
            "os_type": "linux",
            "password": null,
            "ports": [
                80
            ],
            "profile": null,
            "registry_login_server": null,
            "registry_password": null,
            "registry_username": null,
            "resource_group": "MyAzureResourceGroup",
            "restart_policy": null,
            "secret": null,
            "state": "absent",
            "subscription_id": null,
            "tags": null,
            "tenant": null,
            "volumes": [
                {
                    "azure_file": {
                        "read_only": null,
                        "share_name": "my-fileshare",
                        "storage_account_key": "x3xaeDCHZxk3Jnm3/lHX9xaNCCzU4hwXN9OMw2GjBRva3ybVzQ+uc2TgAOcQzi/IV6OzHzt/5SM0JmU1xdjA6Q==",
                        "storage_account_name": "mystorageaccountap"
                    },
                    "empty_dir": null,
                    "git_repo": null,
                    "name": "my-filesharevolume",
                    "secret": null
                }
            ]
        }
    },
    "state": {}
}
Read vars_file 'integration_config.yml'
META: role_complete for testhost
Read vars_file 'integration_config.yml'
META: ran handlers
Read vars_file 'integration_config.yml'
META: ran handlers

PLAY RECAP ************************************************************************************************************************************************************************************************
testhost                   : ok=8    changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

Run command: /usr/bin/python /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Run command: /usr/bin/python3 /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python3
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Run command: /usr/bin/python3.8 /root/ansible/test/lib/ansible_test/_data/versions.py
Working directory: /root/ansible
Program found: /usr/bin/python3.8
HOME=/root
LC_ALL=en_US.UTF-8
PATH=/root/ansible/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Cleaning up temporary python directory: /tmp/python-410n1wz8-ansible

Fred-sun

@aparna-patil Could you please help to authorize me to update this PR? Thank you very much!

tests/sanity/ignore-2.11.txt

aparna-patil · 2021-06-25T06:06:01Z

@aparna-patil Could you please help to authorize me to update this PR? Thank you very much!

@Fred-sun Provided the access, could you please verify once? Thank you!

Fred-sun · 2021-06-25T07:16:04Z

@aparna-patil Can you execute the test case as follows? The result of my arrival was fail。

---
- name: Run test suite for module
  hosts: localhost
  connection: local
  vars:
    resource_group: my-test-rg
  tasks:
    - name: create prerequisite resource group
      azure.azcollection.azure_rm_resourcegroup:
        name: "{{ resource_group }}"
        location: eastus
    - include: ../tests/integration/targets/azure_rm_appgateway/tasks/main.yml

aparna-patil · 2021-06-25T07:22:02Z

@aparna-patil Can you execute the test case as follows? The result of my arrival was fail。

---
- name: Run test suite for module
  hosts: localhost
  connection: local
  vars:
    resource_group: my-test-rg
  tasks:
    - name: create prerequisite resource group
      azure.azcollection.azure_rm_resourcegroup:
        name: "{{ resource_group }}"
        location: eastus
    - include: ../tests/integration/targets/azure_rm_appgateway/tasks/main.yml

@Fred-sun Sure, let me try this way.. Could you please share the failure details for reference?

Fred-sun · 2021-06-25T08:21:35Z

@aparna-patil Okay, I'll share it with you later.

tests/integration/targets/azure_rm_containerinstance/tasks/main.yml

Fred-sun · 2021-08-02T05:55:32Z

@aparna-patil Can you help resolve conflicting files? I will move forward with the merger as soon as possible. Thank you very much!

aparna-patil · 2021-08-02T09:22:20Z

@aparna-patil Can you help resolve conflicting files? I will move forward with the merger as soon as possible. Thank you very much!

@Fred-sun Done, Resolved merge conflicts. Thank you!

Fred-sun · 2021-08-03T08:55:52Z

@aparna-patil Thanks for your udpate! I will push for merged as soon as possible!

Fred-sun · 2021-08-11T12:24:53Z

@aparna-patil Can you help resolve conflicting files? I will move forward with the merger as soon as possible. Thank you very much!

aparna-patil · 2021-09-15T09:31:36Z

@aparna-patil Can you help resolve conflicting files? I will move forward with the merger as soon as possible. Thank you very much!

@Fred-sun Done! resolved merge conflicts. Thank you!

aparna-patil · 2021-10-06T12:33:30Z

Hi @Fred-sun Could you please help push this for merge whenever you get time? Actually this PR is stuck from last year. Thank you very much for your help!

Fred-sun · 2021-10-07T15:36:00Z

Hi @Fred-sun Could you please help push this for merge whenever you get time? Actually this PR is stuck from last year. Thank you very much for your help!

@aparna-patil I'm working on it. Thank you very much!

xuzhang3 · 2021-10-14T07:53:09Z

LGTM

…ntainer instances (ansible-collections#338) * Fixed issue ansible-collections#232 Added Volume mount support for container instances * Updated Sanity test file * Changed the name for filesharevolume * Updated sanity files and tests file as per review comments * Updated integration tests * updated sanity test file * Ignore errors in the test cases * fix sanity error Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> Co-authored-by: Fred-sun <xiuxi.sun@qq.com>

Fixed issue #232 Added Volume mount support for container instances

a43125b

Fred-sun reviewed Nov 30, 2020

View reviewed changes

Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Nov 30, 2020

Updated Sanity test file

46d2656

Merge branch 'dev' into 232-volumeSupportForContainerInstances

0c522f5

aparna-patil requested a review from Fred-sun December 22, 2020 09:51

aparna-patil and others added 2 commits February 25, 2021 14:44

Merge branch 'dev' into 232-volumeSupportForContainerInstances

43d5641

Changed the name for filesharevolume

9d8eaf4

Merge branch 'dev' into 232-volumeSupportForContainerInstances

0c55ad3

Fred-sun reviewed Mar 10, 2021

View reviewed changes

tests/integration/targets/azure_rm_containerinstance/tasks/main.yml Outdated Show resolved Hide resolved

aparna-patil added 2 commits March 12, 2021 12:57

Updated sanity files and tests file as per review comments

c71be67

Merge branch '232-volumeSupportForContainerInstances' of https://gith…

2df51d7

…ub.com/aparna-patil/azure into 232-volumeSupportForContainerInstances

aparna-patil requested a review from Fred-sun March 12, 2021 07:51

Merge branch 'dev' into 232-volumeSupportForContainerInstances

0b61588

Merge branch 'dev' into 232-volumeSupportForContainerInstances

55da589

aparna-patil added 2 commits April 12, 2021 18:42

Merge branch 'dev' into 232-volumeSupportForContainerInstances

8b0f17d

Merge branch 'dev' into 232-volumeSupportForContainerInstances

e3a6540

haiyuazhang force-pushed the dev branch from 380c7d8 to e5a5734 Compare May 12, 2021 10:57

Merge branch 'dev' into 232-volumeSupportForContainerInstances

359d07e

Fred-sun reviewed Jun 25, 2021

View reviewed changes

tests/sanity/ignore-2.11.txt Show resolved Hide resolved

Fred-sun reviewed Jun 25, 2021

View reviewed changes

tests/integration/targets/azure_rm_containerinstance/tasks/main.yml Show resolved Hide resolved

aparna-patil and others added 3 commits June 25, 2021 17:55

updated sanity test file

a0a84fd

Ignore errors in the test cases

c2ad60a

fix sanity error

6b11edf

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 28, 2021

aparna-patil added 2 commits August 2, 2021 14:27

Resolved merge conflicts

63271ed

Resolved merge conflicts

bbfa096

Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels Aug 11, 2021

Resolved merge conflicts

7b94f3f

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Oct 11, 2021

xuzhang3 merged commit 113470b into ansible-collections:dev Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issue #232 Added Volume mount support for container instances #338

Fixed issue #232 Added Volume mount support for container instances #338

aparna-patil commented Nov 26, 2020

aparna-patil commented Nov 26, 2020

Fred-sun commented Nov 30, 2020

Fred-sun Nov 30, 2020

aparna-patil Dec 3, 2020

aparna-patil Dec 22, 2020

aparna-patil commented Dec 3, 2020

aparna-patil commented Feb 26, 2021

aparna-patil commented Mar 1, 2021

Fred-sun commented Mar 10, 2021

aparna-patil commented Mar 12, 2021

Ompragash commented Apr 6, 2021

Fred-sun commented Apr 6, 2021

aparna-patil commented Apr 11, 2021

aparna-patil commented Jun 22, 2021

Fred-sun left a comment

aparna-patil commented Jun 25, 2021

Fred-sun commented Jun 25, 2021

aparna-patil commented Jun 25, 2021

Fred-sun commented Jun 25, 2021

Fred-sun commented Aug 2, 2021

aparna-patil commented Aug 2, 2021

Fred-sun commented Aug 3, 2021

Fred-sun commented Aug 11, 2021

aparna-patil commented Sep 15, 2021

aparna-patil commented Oct 6, 2021

Fred-sun commented Oct 7, 2021

xuzhang3 commented Oct 14, 2021

Fixed issue #232 Added Volume mount support for container instances #338

Fixed issue #232 Added Volume mount support for container instances #338

Conversation

aparna-patil commented Nov 26, 2020

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

aparna-patil commented Nov 26, 2020

Fred-sun commented Nov 30, 2020

Fred-sun Nov 30, 2020

Choose a reason for hiding this comment

aparna-patil Dec 3, 2020

Choose a reason for hiding this comment

aparna-patil Dec 22, 2020

Choose a reason for hiding this comment

aparna-patil commented Dec 3, 2020

aparna-patil commented Feb 26, 2021

aparna-patil commented Mar 1, 2021

Fred-sun commented Mar 10, 2021

aparna-patil commented Mar 12, 2021

Ompragash commented Apr 6, 2021

Fred-sun commented Apr 6, 2021

aparna-patil commented Apr 11, 2021

aparna-patil commented Jun 22, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

aparna-patil commented Jun 25, 2021

Fred-sun commented Jun 25, 2021

aparna-patil commented Jun 25, 2021

Fred-sun commented Jun 25, 2021

Fred-sun commented Aug 2, 2021

aparna-patil commented Aug 2, 2021

Fred-sun commented Aug 3, 2021

Fred-sun commented Aug 11, 2021

aparna-patil commented Sep 15, 2021

aparna-patil commented Oct 6, 2021

Fred-sun commented Oct 7, 2021

xuzhang3 commented Oct 14, 2021