New module: azure_rm_notificationhub #496

praveenghuge · 2021-04-18T17:10:36Z

SUMMARY
This module introduces a wide variety of configurations for creating a Notification Hub Namespace and Notification Hub on Azure.
Create Notification Hub Namespace on Azure.
Create Notification Hub on Azure.
Update Notification Hub Namespace on Azure.
Update Notification Hub on Azure.
Delete Notification Hub Namespace on Azure.
Delete Notification Hub on Azure.
Get Notification Hub Namespace on Azure.
Get Notification Hub on Azure.

ISSUE TYPE
New Module Pull Request
COMPONENT NAME
azure_rm_notificationhub

ADDITIONAL INFORMATION
This module allows users to create/update or delete the Notification Hub Namespace and Notification Hub on Azure.
It also provides all the parameters given by:
https://docs.microsoft.com/en-us/azure/templates/microsoft.notificationhubs/namespaces?tabs=json
https://docs.microsoft.com/en-us/azure/templates/microsoft.notificationhubs/namespaces/notificationhubs?tabs=json

More information

  azure_rm_notificationhub:
    resource_group: testgroupans
    location: eastus
    namespace_name: myNamespace
    tags:
       - a: b
    sku: free

Fred-sun · 2021-04-19T06:13:44Z

@praveenghuge Thanks for your contribution! I'm working in!

Fred-sun

@praveenhuge There is no content in aliase.

cloud/azure
shippable/azure/group10
destructive

plugins/module_utils/azure_rm_common.py

plugins/modules/azure_rm_notificationhub.py

plugins/modules/azure_rm_notificationhub_info.py

Fred-sun

@praveenghuge You can also check for sanity problems in PR via links(https://docs.ansible.com/ansible/latest/dev_guide/testing_sanity.html)! Thank you very much!

plugins/modules/azure_rm_notificationhub_info.py

plugins/modules/azure_rm_notificationhub.py

Fred-sun

@praveenghuge Please increase update and get block to your playbook --tests/integration/targets/azure_rm_notificationhub/tasks/main.yml . Anyway, please share the result of you execute "tests/integration/targets/azure_rm_notificationhub/tasks/main.yml". Thank you very much!

plugins/modules/azure_rm_notificationhub.py

praveenghuge · 2021-04-19T10:31:06Z

i was not able to run integration test on local adding the output the test we performed while creating the resources on azure portal

create namespace

playbook:

   connection: local
   tasks:

    - name: Create Namespace (check mode yes)
      azure.azcollection.azure_rm_notificationhub:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        location: XXX
        namespace_name: testnaedd3d22d3w
        resource_group: test
        tags:
                a: b
                b: c
        sku: free
      check_mode: yes

output

changed: [localhost] => {
    "changed": true,
    "check_mode": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "name": null,
            "namespace_name": "testnaedd3d22d3w",
            "password": null,
            "profile": null,
            "resource_group": "test",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "sku": "free",
            "state": "present",
            "subscription_id": "xxxx",
            "tags": {
                "a": "b",
                "b": "c"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {}
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-19T10:34:36Z

playbook

   connection: local
   tasks:

    - name: Create Namespace 
      azure.azcollection.azure_rm_notificationhub:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        location: XXX
        namespace_name: testnaedd3d22d3w
        resource_group: test
        tags:
                a: b
                b: c
        sku: free

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "name": null,
            "namespace_name": "testnaedd3d22d3w",
            "password": null,
            "profile": null,
            "resource_group": "test",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "sku": "free",
            "state": "present",
            "subscription_id": "XXXX",
            "tags": {
                "a": "b",
                "b": "c"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "critical": null,
        "data_center": null,
        "enabled": false,
        "location": "eastus2",
        "metric_id": null,
        "name": "testnaedd3d22d3w",
        "namespace_type": "NotificationHub",
        "provisioning_state": "Unknown",
        "region": null,
        "scale_unit": null,
        "service_bus_endpoint": null,
        "sku": "free",
        "tags": {
            "a": "b",
            "b": "c"
        },
        "type": "Microsoft.NotificationHubs/namespaces"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-19T10:37:32Z

playbook

   connection: local
   tasks:

    - name: Update Namespace  free to basic
      azure.azcollection.azure_rm_notificationhub:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        location: XXX
        namespace_name: testnaedd3d22d3w
        resource_group: test
        tags:
                a: b
                b: c
        sku: basic

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "name": null,
            "namespace_name": "testnaedd3d22d3w",
            "password": null,
            "profile": null,
            "resource_group": "test",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "sku": "basic",
            "state": "present",
            "subscription_id": "XXXXX",
            "tags": {
                "a": "b",
                "b": "c"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "critical": null,
        "data_center": null,
        "enabled": false,
        "location": "eastus2",
        "metric_id": null,
        "name": "testnaedd3d22d3w",
        "namespace_type": "NotificationHub",
        "provisioning_state": "Succeeded",
        "region": null,
        "scale_unit": null,
        "service_bus_endpoint": null,
        "sku": "basic",
        "tags": {
            "a": "b",
            "b": "c"
        },
        "type": "Microsoft.NotificationHubs/namespaces"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-19T10:39:50Z

playbook

   connection: local
   tasks:

    - name: create namespace (idempotent)
      azure.azcollection.azure_rm_notificationhub:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        location: XXX
        namespace_name: testnaedd3d22d3w
        resource_group: test
        tags:
                a: b
                b: c
        sku: basic

output

ok: [localhost] => {
    "changed": false,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "name": null,
            "namespace_name": "testnaedd3d22d3w",
            "password": null,
            "profile": null,
            "resource_group": "test",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "sku": "basic",
            "state": "present",
            "subscription_id": "Xxxx",
            "tags": {
                "a": "b",
                "b": "c"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "critical": false,
        "data_center": null,
        "enabled": true,
        "location": "eastus2",
        "metric_id": null,
        "name": "testnaedd3d22d3w",
        "namespace_type": "NotificationHub",
        "provisioning_state": "Succeeded",
        "region": null,
        "scale_unit": null,
        "service_bus_endpoint": "https://testnaedd3d22d3w.servicebus.windows.net:443/",
        "sku": "Basic",
        "tags": {
            "a": "b",
            "b": "c"
        },
        "type": "Microsoft.NotificationHubs/namespaces"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-19T10:42:20Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Delete Notification Hub Namespace
      azure.azcollection.azure_rm_notificationhub:
        subscription_id: XXXXX
        tenant: XXX
        client_id: XXXX
        secret: XXXXX
        resource_group: test
        namespace_name: testnaedd3d22d3w
        state: absent

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": null,
            "name": null,
            "namespace_name": "testnaedd3d22d3w",
            "password": null,
            "profile": null,
            "resource_group": "test",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "sku": "free",
            "state": "absent",
            "subscription_id": "XXxx",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "critical": false,
        "data_center": null,
        "enabled": true,
        "location": "eastus2",
        "metric_id": null,
        "name": "testnaedd3d22d3w",
        "namespace_type": "NotificationHub",
        "provisioning_state": "Succeeded",
        "region": null,
        "scale_unit": null,
        "service_bus_endpoint": "https://testnaedd3d22d3w.servicebus.windows.net:443/",
        "sku": "Basic",
        "status": "Deleted",
        "tags": {
            "a": "b",
            "b": "c"
        },
        "type": "Microsoft.NotificationHubs/namespaces"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T05:21:11Z

@Fred-sun addressed the changes requested.
Thanks for the review 👍

Fred-sun

@Fred-sun addressed the changes requested.
Thanks for the review 👍

@praveenghuge I have been busy with upgrade Python versions recently. Sorry for not replying in time! Thank you very much!

plugins/modules/azure_rm_notificationhub.py

plugins/modules/azure_rm_notificationhub_info.py

plugins/modules/azure_rm_notificationhub.py

praveenghuge · 2021-04-28T17:32:50Z

Hi @Fred-sun can you please review the PR.
thank you so much

…ections#524)

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml

Fred-sun · 2021-05-28T02:15:42Z

@praveenghuge The test case needs to make minor changes. Thank you very much!

Fred-sun · 2021-05-28T23:47:00Z

@praveenghuge Please help to resolve the conflict file and make a minor changes for the playbook! Thank you very much!

plugins/module_utils/azure_rm_common.py

praveenghuge · 2021-05-29T15:36:15Z

Hi @Fred-sun can you please review the PR. addressed the changes
thank you so much 👍

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml

plugins/module_utils/azure_rm_common.py

Fred-sun · 2021-05-29T23:06:28Z

@praveenghuge Please delete azure_rm_expressrouter_info.py, This PR relate with azure_rm_notification* module! Thank you very much!

Fred-sun

@praveenghuge One last update requirement! please!

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml

praveenghuge · 2021-06-10T12:20:20Z

@Fred-sun updated the latest version
Can you please review
Thank you so much 👍

Fred-sun · 2021-06-10T12:32:22Z

@praveenghuge Great! Waiting merged!

praveenghuge · 2021-06-23T17:10:59Z

@Fred-sun can we merge this? if there is something to work on will pick up. Thanks

Fred-sun · 2021-06-24T05:39:41Z

@praveenghuge Recently, delayed the merger. I will push the merger as soon as possible! Thank you very much!

xuzhang3 · 2021-06-24T05:49:01Z

LGTM

* notification hub changes * integration changes * new changes * remaining changes * remaining changes * address changes * address changes * minor change * address comments * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * update version Co-authored-by: Praveen Ghuge <pravin94ghuge@gmail.com> Co-authored-by: haiyuan_zhang <haiyuan.zhang1982@gmail.com> Co-authored-by: Praveen Ghuge <praghuge@in.ibm.com>

pravin94ghuge added 5 commits April 16, 2021 06:43

notification hub changes

c1cd13a

integration changes

1e606c5

new changes

9f78200

remaining changes

dffa480

remaining changes

f6e2eab

praveenghuge changed the title ~~Notification hub~~ New Module [Notification hub] Apr 18, 2021

Merge branch 'dev' into notification_hub

e1273b2

Fred-sun added medium_priority Medium priority new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Apr 19, 2021

Fred-sun reviewed Apr 19, 2021

View reviewed changes

plugins/modules/azure_rm_notificationhub.py Show resolved Hide resolved

pravin94ghuge added 2 commits April 19, 2021 02:36

address changes

cfed377

address changes

e61414d

praveenghuge and others added 2 commits April 22, 2021 11:06

Merge branch 'dev' into notification_hub

c1be8b9

minor change

5591b9c

Fred-sun reviewed Apr 22, 2021

View reviewed changes

pravin94ghuge and others added 3 commits April 22, 2021 19:28

address comments

5707518

Merge branch 'dev' into notification_hub

60d9c30

Merge branch 'dev' into notification_hub

9165008

fixing update account_enabled bug in azure_rm_aduser.py (ansible-coll…

c3e6d59

…ections#524)

Fred-sun reviewed May 25, 2021

View reviewed changes

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Outdated Show resolved Hide resolved

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Outdated Show resolved Hide resolved

Fred-sun reviewed May 28, 2021

View reviewed changes

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Outdated Show resolved Hide resolved

praveenghuge and others added 2 commits May 29, 2021 19:39

Merge branch 'dev' into notification_hub

a92b147

address changes

27a1cc9

Fred-sun reviewed May 29, 2021

View reviewed changes

plugins/module_utils/azure_rm_common.py Show resolved Hide resolved

plugins/module_utils/azure_rm_common.py Outdated Show resolved Hide resolved

address changes

5e04e3f

Fred-sun reviewed May 29, 2021

View reviewed changes

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Outdated Show resolved Hide resolved

plugins/module_utils/azure_rm_common.py Outdated Show resolved Hide resolved

plugins/module_utils/azure_rm_common.py Outdated Show resolved Hide resolved

address changes

bb7e20d

This comment has been minimized.

Sign in to view

address changes

a36ad4c

Fred-sun reviewed May 31, 2021

View reviewed changes

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Show resolved Hide resolved

tests/integration/targets/azure_rm_notificationhub/tasks/main.yml Show resolved Hide resolved

Praveen Ghuge added 2 commits May 31, 2021 08:55

address changes

0ba9d70

address changes

f362cdd

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 31, 2021

praveenghuge and others added 3 commits June 7, 2021 13:04

Merge branch 'dev' into notification_hub

9cd826a

update version

0240964

Merge branch 'dev' into notification_hub

6e42db6

Merge branch 'dev' into notification_hub

70b3541

xuzhang3 merged commit f63d6e9 into ansible-collections:dev Jun 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New module: azure_rm_notificationhub #496

New module: azure_rm_notificationhub #496

praveenghuge commented Apr 18, 2021 •

edited

Loading

Fred-sun commented Apr 19, 2021

Fred-sun left a comment

Fred-sun left a comment •

edited

Loading

Fred-sun left a comment

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021

Fred-sun left a comment

praveenghuge commented Apr 28, 2021

Fred-sun commented May 28, 2021

Fred-sun commented May 28, 2021

praveenghuge commented May 29, 2021

This comment has been minimized.

Fred-sun commented May 29, 2021

Fred-sun left a comment

praveenghuge commented Jun 10, 2021

Fred-sun commented Jun 10, 2021 •

edited

Loading

praveenghuge commented Jun 23, 2021

Fred-sun commented Jun 24, 2021

xuzhang3 commented Jun 24, 2021

New module: azure_rm_notificationhub #496

New module: azure_rm_notificationhub #496

Conversation

praveenghuge commented Apr 18, 2021 • edited Loading

Fred-sun commented Apr 19, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

Fred-sun left a comment • edited Loading

Choose a reason for hiding this comment

Fred-sun left a comment

Choose a reason for hiding this comment

praveenghuge commented Apr 19, 2021 • edited Loading

praveenghuge commented Apr 19, 2021 • edited Loading

praveenghuge commented Apr 19, 2021 • edited Loading

praveenghuge commented Apr 19, 2021 • edited Loading

praveenghuge commented Apr 19, 2021 • edited Loading

praveenghuge commented Apr 20, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

praveenghuge commented Apr 28, 2021

Fred-sun commented May 28, 2021

Fred-sun commented May 28, 2021

praveenghuge commented May 29, 2021

This comment has been minimized.

Fred-sun commented May 29, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

praveenghuge commented Jun 10, 2021

Fred-sun commented Jun 10, 2021 • edited Loading

praveenghuge commented Jun 23, 2021

Fred-sun commented Jun 24, 2021

xuzhang3 commented Jun 24, 2021

praveenghuge commented Apr 18, 2021 •

edited

Loading

Fred-sun left a comment •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

praveenghuge commented Apr 19, 2021 •

edited

Loading

Fred-sun commented Jun 10, 2021 •

edited

Loading