Add ability to upgrade nodepool kubernetes version #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
Aug 31, 2022
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
|
@dhageman I tested this parameter, and it seems that this "orchestrator_version" is consistent with"kubernetes_version". Would you like to try it? |
|
@Fred-sun - Setting a new value for kubernetes_version will only upgrade the control plane of a cluster. The node pool supporting the cluster will not be upgraded at all which is why this modification is needed. I imagine that most people will just set both to be the same version when doing upgrades but the flexibility of doing upgrades individually may be nice for some. |
|
@dhageman LGTM 🚢 |
xuzhang3
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current version of azure_rm_aks.py can only upgrade the control plane on an Azure Kubernetes Service. This PR adds a parameter under the node pool profile called "orchestrator_version" that can be used to activate a kubernetes upgrade for the node pool.
ISSUE TYPE
COMPONENT NAME
azure_rm_aks.py
ADDITIONAL INFORMATION
The control plane is upgraded using the kubernetes_version on the module.
The node pool is upgraded using orchestrator_version in the agent_pool_profiles.