Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure_vm_virtualnetworkgatewayconnection module #982

Closed

Conversation

NilashishC
Copy link

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
  • Add module to create, update or delete Azure Virtual Network Gateway Connections.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_vm_virtualnetworkgatewayconnection.py

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@Fred-sun Fred-sun added new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Sep 26, 2022
self.name = None
self.state = None
self.location = None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A local gateway is required when type is 'IPSec', while the second virtual gateway is required when type is 'Vnet2Vnet'; so I'd add here:

        required_if = [
            ('connection_type', 'IPsec', ['name', 'local_network_gateway2']),
            ('connection_type', 'Vnet2Vnet', ['name', 'virtual_network_gateway2'])
        ]

and then pass it to the super contructor

name=dict(type='str', required=True),
state=dict(type='str', default='present', choices=['present', 'absent']),
location=dict(type='str'),
virtual_network_gateway1=dict(type='str', required=False),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far I can see, virtual_network_gateway is required for "IPsec", "Vnet2Vnet" and "ExpressRoute"; not sure about "VPNClient" which the azure console does not offer as an option.

@Fred-sun Fred-sun added has_pr PR fixes have been made and removed work in In trying to solve, or in working with contributors labels Apr 25, 2024
@Fred-sun Fred-sun removed the has_pr PR fixes have been made label May 13, 2024
@Fred-sun
Copy link
Collaborator

Already supported in #1627

@Fred-sun Fred-sun closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_module_pr Add new modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants