lint: fix some violations and add initial config #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one.
Andersson007
approved these changes
May 23, 2023
|
@Andersson007 I do not have, could prove useful. |
you now have |
Andersson007
added
backport-4
backport-5
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #549 🤖 @patchback |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #550 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 23, 2023
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8)
patchback bot
pushed a commit
that referenced
this pull request
May 23, 2023
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8)
This was referenced May 23, 2023
|
@ssbarnea you can backport changes by putting |
Andersson007
pushed a commit
that referenced
this pull request
May 24, 2023
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8) Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Andersson007
pushed a commit
that referenced
this pull request
May 24, 2023
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8) Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not fix yet. We will fix these in follow-ups one by one.
Related: ansible/ansible-lint#3482