-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: fix some violations and add initial config #548
Conversation
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you have commit here?
@Andersson007 I do not have, could prove useful. |
you now have |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #549 🤖 @patchback |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #550 🤖 @patchback |
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8)
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8)
@ssbarnea you can backport changes by putting |
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8) Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
- Fixes 3 simple violations reported by linter - Introduce initial config that disables some rules that we did not fix yet. We will fix these in follow-ups one by one. (cherry picked from commit 312b5d8) Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
not fix yet. We will fix these in follow-ups one by one.
Related: ansible/ansible-lint#3482