Add IPv4 DHCP option matcher, minor fixes #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Without the default value removing it from the options after it's been set once leads to an error: > Key "force" cannot be removed for name="…"
RouterOS 7.4 and newer implement matchers for the Vendor ID provided by DHCP clients. RouterOS 7.16 will add a new `matching-type` property, but it's not in a stable release yet. Upstream documentation: https://help.mikrotik.com/docs/display/ROS/DHCP#DHCP-Genericmatcher
felixfontein
approved these changes
Jul 21, 2024
|
@hansmi thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
RouterOS 7.4 and newer implement matchers for the Vendor ID provided by DHCP clients under
ip dhcp-server matcher. The default value forforceon options is also set.ISSUE TYPE