Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.0prep #837

Merged
merged 5 commits into from
Nov 27, 2022
Merged

1.9.0prep #837

merged 5 commits into from
Nov 27, 2022

Conversation

BGmot
Copy link
Collaborator

@BGmot BGmot commented Nov 6, 2022

SUMMARY

New colellction version PR.

Fixes #832

ISSUE TYPE
  • New collection version Pull Request

Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait a couple more days for #787 resolution

@BGmot
Copy link
Collaborator Author

BGmot commented Nov 6, 2022

Thanks for reviewing and guiding through this!

@johansenha
Copy link
Contributor

@D3DeFi since #787 is merged can we apply the change to release 1.9.0?

@D3DeFi
Copy link
Contributor

D3DeFi commented Nov 25, 2022

@D3DeFi since #787 is merged can we apply the change to release 1.9.0?

yep :) sole reason we waited with this PR is that issue :)

@BGmot can you please rebase this PR a top of latest main changes and re-run antsibull-changleg with updated date? I will try to merge it on the same day you update and then you can push tag to release on galaxy

@BGmot
Copy link
Collaborator Author

BGmot commented Nov 25, 2022

Can we squeeze in one more #526 ?

@D3DeFi
Copy link
Contributor

D3DeFi commented Nov 25, 2022

Can we squeeze in one more #526 ?

Sure, there is zero rush to release :)

Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@BGmot BGmot merged commit 56a9d6a into ansible-collections:main Nov 27, 2022
@BGmot
Copy link
Collaborator Author

BGmot commented Nov 27, 2022

Hope I did everything right.
Not sure about Galaxy steps - where do we disable/enable automatic publish? I still see 1.8.0 in Galaxy.

Additional manual steps are required when automatic publish to Ansible Galaxy is not enabled in the repository.

@BGmot
Copy link
Collaborator Author

BGmot commented Nov 27, 2022

Oh, nevermind, I see 1.9 in Galaxy now. So fingeres crossed now and let's embrace for bug reports flow.

@D3DeFi
Copy link
Contributor

D3DeFi commented Nov 27, 2022

Thanks for publishing! :)

@BGmot
Copy link
Collaborator Author

BGmot commented Nov 27, 2022

Thanks for publishing! :)

Thanks for guidance -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.9.0
3 participants