-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param ordering note to plugins page. #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please add a changelog fragment. Thanks.
I've included your suggestions and also added a changelog. |
You are not changing documentation, but templates (and these are code). |
Do you want to make some more updates? I can also push some updates if you don't have time. There will be a new release of antsibull-docs in a couple of days, it would be nice if this PR can also make it in there. |
Add a note to every filter, test, and lookup to list positional parameters before keyword ones.
Changes done by this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the opportunity at the moment to test this locally but based on the before/after links.. LGTM
This is now live on the Ansible devel docsite btw: https://docs.ansible.com/ansible/devel/collections/ansible/builtin/combine_filter.html#notes |
Add a note to every filter, test, and lookup to list positional parameters before keyword ones.
Relates to reviewer note ansible/ansible#80078 (comment) within ansible/ansible#80078