-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use currently installed ansible-core for devel and stable subcommands #121
Allow to use currently installed ansible-core for devel and stable subcommands #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other small docs suggestion. Otherwise, this looks good to me. Thanks!
stable_parser.add_argument('--use-installed-ansible-core', action='store_true', | ||
help='Assumes that ansible-core is already installed and can be' | ||
' used by calling `ansible`, `ansible-doc`, and `ansible-galaxy`' | ||
' from $PATH.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stable_parser.add_argument('--use-installed-ansible-core', action='store_true', | |
help='Assumes that ansible-core is already installed and can be' | |
' used by calling `ansible`, `ansible-doc`, and `ansible-galaxy`' | |
' from $PATH.') | |
help='Assumes that ansible-core is already installed and can be' | |
' used by calling `ansible`, `ansible-doc`, and `ansible-galaxy`' | |
' from $PATH.' | |
' By default, antsibull-docs installs ansible-core into a temporary venv.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this PR is still missing one necessary change. It doesn't look like it provides a way to preserve PYTHONPATH
, which is being removed here:
del ANSIBLE_PATH_ENVIRON['PYTHONPATH'] |
This prevents antsibull-docs from recognizing the ansible-core that is injected into the virtual environment.
Co-authored-by: Maxwell G <maxwell@gtmx.me>
4d950f3
to
5990873
Compare
@felixfontein Do you have an idea of when you'll be releasing a version with this change? |
@mattclay first antsibull-core 2.0.0 needs to be released before antsibull-docs 2.0.0 can be released (which will contain this change). We're in the middle of preparing both; I'm right now not sure how long this will take. I hope/think/assume both will be done in a couple of weeks, but it depends a lot on when/how much @gotmax23 and me have time to work on it... |
Is this worth backporting? |
It's a feature, so no backport. |
CC @mattclay