Allow to use currently installed ansible-core for devel and stable subcommands

[felixfontein]

CC @mattclay

[gotmax23]

One other small docs suggestion. Otherwise, this looks good to me. Thanks!

[gotmax23]

Suggested change

	stable_parser.add_argument('--use-installed-ansible-core', action='store_true',
	help='Assumes that ansible-core is already installed and can be'
	' used by calling `ansible`, `ansible-doc`, and `ansible-galaxy`'
	' from $PATH.')
	help='Assumes that ansible-core is already installed and can be'
	' used by calling `ansible`, `ansible-doc`, and `ansible-galaxy`'
	' from $PATH.'
	' By default, antsibull-docs installs ansible-core into a temporary venv.')

[mattclay]

It seems this PR is still missing one necessary change. It doesn't look like it provides a way to preserve PYTHONPATH, which is being removed here:

antsibull-docs/src/antsibull_docs/docs_parsing/__init__.py

Line 34 in 489da64

del ANSIBLE_PATH_ENVIRON['PYTHONPATH']

This prevents antsibull-docs from recognizing the ansible-core that is injected into the virtual environment.

[felixfontein]

@gotmax23 @mattclay thanks for reviewing this!

[mattclay]

@felixfontein Do you have an idea of when you'll be releasing a version with this change?

[felixfontein]

@mattclay first antsibull-core 2.0.0 needs to be released before antsibull-docs 2.0.0 can be released (which will contain this change). We're in the middle of preparing both; I'm right now not sure how long this will take. I hope/think/assume both will be done in a couple of weeks, but it depends a lot on when/how much @gotmax23 and me have time to work on it...

[gotmax23]

Is this worth backporting?

[felixfontein]

It's a feature, so no backport. stable-1 is reserved for bugfixes (so we can update antsibull-docs in ansible-core 2.15).