Fix bugs in choices #276
Merged
Fix bugs in choices #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ansible/ansible#83204.
https://github.com/ansible/ansible/pull/83149/files#diff-fc025deb71887b0e6b0b3280f4dac62412a7e253db3417036dc9ce8d9a9f8e52R24 triggered three bugs in antsibull-docs:
choicesis a dictionary fortype=list, it was treated as a single entry in the choices list for validation purposes (resulting in a validation error).choicesis a dictionary fortype=list, the normalized result was recombined incorrectly, resulting in a list with a single entry.defaultis present fortype=listwithchoices, rendering fails withTypeError: unhashable type: 'list'. (This only happens after 1. is fixed.)