-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback plugins: show type, render indexes of callback plugins per type #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably didn't need to change the nits in the test files but I was half-way thru before I realized I was... in test files ;-)
tests/functional/baseline-default/collections/index_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-default/collections/ns2/col/foo_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-no-breadcrumbs/collections/index_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-no-breadcrumbs/collections/ns2/col/foo_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-no-indexes/collections/ns2/col/foo_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-use-html-blobs/collections/index_callback.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-use-html-blobs/collections/ns2/col/foo_callback.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sandra McCann <samccann@redhat.com>
CI failure is unrelated. |
Fixes #89.
Examples: