Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback plugins: show type, render indexes of callback plugins per type #90

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

@felixfontein felixfontein changed the title [WIP] Callback plugins: show type, render indexes of callback plugins per type Callback plugins: show type, render indexes of callback plugins per type Jan 4, 2023
@felixfontein felixfontein marked this pull request as ready for review January 4, 2023 18:58
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably didn't need to change the nits in the test files but I was half-way thru before I realized I was... in test files ;-)

Co-authored-by: Sandra McCann <samccann@redhat.com>
@felixfontein
Copy link
Collaborator Author

CI failure is unrelated.

@felixfontein felixfontein merged commit 0b0e44c into ansible-community:main Jan 11, 2023
@felixfontein felixfontein deleted the callbacks branch January 11, 2023 18:45
@felixfontein
Copy link
Collaborator Author

@oraNod @samccann thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show callback type
3 participants