Explicitly declare and restrict sh dependency to < 2.0.0, and also declare other dependencies that is directly imported #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
felixfontein
commented
Feb 23, 2023
gotmax23
reviewed
Feb 24, 2023
| # sh v2 has breaking changes. | ||
| # https://github.com/ansible-community/antsibull-core/issues/34 | ||
| sh = ">= 1.0.0 < 2.0.0" | ||
| pydantic = "*" |
There was a problem hiding this comment.
pydantic is the subject of a major rewrite. We might want to pin this to < 2.0.0.
There was a problem hiding this comment.
In any case, this constraint should be the same between antsibull-docs and and antsibull-core.
There was a problem hiding this comment.
Sounds like a good idea. I'll create a follow-up for that (later today or tomorrow).
There was a problem hiding this comment.
One annoying thing is that pydantic does not adhere to semver, so < 2.0.0 does not prevent breaking changes. But restricting this more is not a good idea either, IMO...
gotmax23
approved these changes
Feb 24, 2023
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.