This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 6
Rely on resource group removal when performing destroy #23
Merged
ssbarnea
merged 4 commits into
ansible-community:master
from
mksha:fix/remove-instance-destruction
Oct 29, 2020
Merged
Rely on resource group removal when performing destroy #23
ssbarnea
merged 4 commits into
ansible-community:master
from
mksha:fix/remove-instance-destruction
Oct 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ssbarnea can you approve it ? |
ssbarnea
suggested changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please do not rename resource group, is the same everywhere.
- You removed the log line without any reason
- In general each change should be atomic and not combine multiple changes
- Linking to a bug and using
Fix: #XYZ
as a comment is recommended. Still for this
change alone (Rely on resource group removal on destroy) we may do it w/o that.
ssbarnea
changed the title
Fix: Renamed rg name to molecule-azure and removed instance destruction
Rely on resource group removal when performing destroy
Jun 1, 2020
ssbarnea
reviewed
Jun 2, 2020
azure_rm_resourcegroup: | ||
name: "{{ resource_group_name }}" | ||
state: absent | ||
force_delete_nonempty: true | ||
force_delete_nonempty: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure yamllint would complain about not using recommended yaml booleans, please use them, even if ansible team does not want to conform to newer YAML standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked yamllint on destroy.yml , its not failing , but i think we should use true
. I will make that changes
ssbarnea
approved these changes
Oct 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13