Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Rely on resource group removal when performing destroy #23

Merged

Conversation

mksha
Copy link
Contributor

@mksha mksha commented May 31, 2020

  • Renamed azure resource group name to molecule-azure from molecule
  • Removed instance and other resource destruction because we already have resource-group destruction tasks that will take care of the destruction of all resources within rg.

Fixes: #13

@mksha
Copy link
Contributor Author

mksha commented May 31, 2020

@ssbarnea can you approve it ?

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please do not rename resource group, is the same everywhere.
  • You removed the log line without any reason
  • In general each change should be atomic and not combine multiple changes
  • Linking to a bug and using Fix: #XYZ as a comment is recommended. Still for this
    change alone (Rely on resource group removal on destroy) we may do it w/o that.

@ssbarnea ssbarnea changed the title Fix: Renamed rg name to molecule-azure and removed instance destruction Rely on resource group removal when performing destroy Jun 1, 2020
azure_rm_resourcegroup:
name: "{{ resource_group_name }}"
state: absent
force_delete_nonempty: true
force_delete_nonempty: yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure yamllint would complain about not using recommended yaml booleans, please use them, even if ansible team does not want to conform to newer YAML standard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked yamllint on destroy.yml , its not failing , but i think we should use true. I will make that changes

@mksha mksha requested a review from ssbarnea June 2, 2020 09:54
@ssbarnea ssbarnea added the enhancement This issue/PR relates to a feature request. label Oct 29, 2020
@ssbarnea ssbarnea merged commit 18acf4d into ansible-community:master Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

destroy can fail with InUseSubnetCannotBeDeleted
2 participants