use RHEL conf for chrony #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Signed-off-by: Tomáš Kuba <tom.kuba@gmail.com>
bbaassssiiee
suggested changes
Feb 14, 2024
templates/chrony.conf.j2
Outdated
| # Note that if Chrony tries to go "online" and dns lookup of the servers | ||
| # fails they will be discarded. Thus under some circumstances it is | ||
| # better to use IP numbers than host names. | ||
| ## This file is managed by Ansible, YOUR CHANGES WILL BE LOST! |
There was a problem hiding this comment.
Why not use conventional {{ ansible_managed | comment }}? The user can redefine whatever the text should be.
Signed-off-by: Tomáš Kuba <tom.kuba@gmail.com>
uk-bolly
approved these changes
Feb 19, 2024
|
Great update, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
replace debian chrony.conf by RHEL8 default conf.
Issue Fixes:
#227
Enhancements:
N/A
How has this been tested?:
N/A