Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements april23 #75

Merged
merged 43 commits into from
Apr 28, 2023
Merged

Improvements april23 #75

merged 43 commits into from
Apr 28, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Apr 13, 2023 •
edited
Loading

Overall Review of Changes:

  • Audit integration
  • fqcn
  • linting and versions
  • idempotent improvements
  • warning method
  • naming tidy up
  • minimum Ansible version
  • workflow update to use audit benchmark version branch

How has this been tested?:
Manually

@uk-bolly
removed MANUAL/AUTOMATED from title
b5c09f1 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Ensure warning is shown
9520d79 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
tidy up alerting on controls
c85b538 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed MANUAL|AUTOMATED from name
fc69bd2 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed Man/auto from name
c8aa167 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed man/auto from name
c5cec7c 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed man/auto.scored from name
f58fa12 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed man/auto from name
ae67d23 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed man/auto from name
0275f36 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed port 80
aa0ab8e 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
spacing
621b0d8 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed file
10f1b98 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated audit components
5cd2f0d 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated audit components
da59cc5 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated ansible version
eca4716 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
tidy up tags
5f41513 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
fixed tmout logic
bfe96e4 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
6.1.1 logic
73357b2 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Added handlers
cb7c006 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated ansible version
0b783c7 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
moved warn count to end
db70a7a 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
improved 1.6.1.3 & 4
ce845b6 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
tidyup scap report
3935feb 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
remove spacing
e5b62ae 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated lint files
090dfaf 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
linting
6916a67 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
fqcn and lint
f5c5b67 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
improved 2.1.1.2 idempotency
07b9bd5 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
fix typo
4cece3a 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Added name to play
48a0438 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
changed state for file
c25c878 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
ec384b4 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
use audit benchmark branch
e1a0675 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
6be9424 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
88be617 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
lint updates
b350fba 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
consistency
6486265 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
dest to path
ec54fa3 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
convert apt to package module
d929f17 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
dest to path
02e4754 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
fix typo
6634865 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
improved 5.1.8/9
55a51c1 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
consistency
f139589 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
georgenalen
georgenalen approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@uk-bolly uk-bolly merged commit 03a3a48 into devel Apr 28, 2023
@uk-bolly uk-bolly deleted the improvements_april23 branch April 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uk-bolly @georgenalen