Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Containerfile parameter #386

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jun 2, 2022

The keyring parameter in Containerfile.__init__() is unused (added in PR #357).

@Shrews Shrews requested a review from a team as a code owner June 2, 2022 18:18
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Jun 2, 2022
Copy link
Contributor

@eqrx eqrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks for finding it! :)

@eqrx eqrx merged commit b80c310 into ansible:devel Jun 2, 2022
@Shrews Shrews deleted the rm-unused-param branch June 2, 2022 19:36
Shrews added a commit to Shrews/ansible-builder that referenced this pull request Jun 2, 2022
Shrews added a commit that referenced this pull request Jun 3, 2022
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants