Add pipopts on install-from-bindep

[tanganellilore]

Team,

this pull request add support to PIP_OPTS on install-from-bindep, as same of assemble file.

So with this implementation we can add it and allow us to use PIP_OPTS option with new v3 format.

[tanganellilore]

@Shrews this is reasonable?

[Shrews]

@Shrews this is reasonable?

It does seem reasonable. The thing we need to put some thought into is tests. We only just incorporated these scripts into this repo from a separate repo (they would normally be expected to exist in the base image, but we get rid of that requirement in this release). Any changes to these scripts, just like the rest of the code, must include a test to validate the change. Unfortunately for you, this is the first PR to one of these scripts, and we do not yet have a testing strategy in place. If you have a good idea for testing this change, I encourage you to add it to the PR and let us evaluate it. Otherwise, the team will need to find time to put our heads together on a testing strategy.

[Shrews]

@tanganellilore Is this change even really necessary? I understand wanting to use PIP_OPTS in assemble, but builder's use of install-from-bindep script is really just to install the wheel packages that were built by assemble. Do we actually gain anything by adding PIP_OPTS support here?

[tanganellilore]

Hi team,
sorry for delay but i was focused on other stuff and other issue on awx project.
What your ad saying @Shrews should be correct, in the assemble we should have all packages that is requested in final step, but this seems not happen in my test env build.

As you can see on this pastebin, after some library that is fetched from "cache" (the output dir of assemble), some new library are requested and pip try to loop on each library to find the correct one.

I try to find why this happen, but anyway, adding an option parameter, not brake anything and increase the possibility to customize pip installation.

Thanks

[tanganellilore]

Hi team,
one more point.
After some discussion with @shanemcd on matrix, I follow him suggestion to upgrade pip in base imge, and seems to work without pipopts in the final stage.

Record log is here: pastebin

I'm still using PIP_OPTS=--use-deprecated=legacy-resolver on other layers