Add install_collection_from_disk method #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Sep 3, 2021
webknjaz
reviewed
Sep 3, 2021
webknjaz
reviewed
Sep 3, 2021
src/ansible_compat/runtime.py
Outdated
Comment on lines
217
to
218
| "--output-path", | ||
| tmp_dir, |
There was a problem hiding this comment.
The option value should reside next to the option value
Suggested change
| "--output-path", | |
| tmp_dir, | |
| "--output-path", tmp_dir, |
There was a problem hiding this comment.
Nope, black will reformat.
There was a problem hiding this comment.
Then add ignores. It's ridiculous when a formatter forces keeping tightly coupled things in different places.
tadeboro
previously requested changes
Sep 3, 2021
webknjaz
reviewed
Sep 3, 2021
ssbarnea
dismissed
tadeboro’s stale review
Fixed, retry is disabled by default.
As ansible-galaxy can install collections from disk only with 2.10+, we add a new method that can be used with all supported versions of Ansible. This also enables install_collection to have a force argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ansible-galaxy can install collections from disk only with 2.10+, we add a new method that can be used with all supported versions of Ansible.
This also enables install_collection to have a force argument.
Related: ansible/molecule#3225 #65