-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
developing_collections_migrating.rst: update #1605
Conversation
ready for review |
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
@oraNod all LGTM, committed, thanks! PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit for grammar and clarity, otherwise LGTM. Thanks @Andersson007
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Don Naro <dnaro@redhat.com>
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/dev_guide/developing_collections_migrating.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
Backport to stable-2.15: 💚 backport PR created✅ Backport PR branch: Backported as #1626 🤖 @patchback |
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48)
Backport to stable-2.16: 💚 backport PR created✅ Backport PR branch: Backported as #1627 🤖 @patchback |
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48)
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #1628 🤖 @patchback |
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48)
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48) Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48) Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com> (cherry picked from commit 91a9b48) Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* developing_collections_migrating.rst: update * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Don Naro <dnaro@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Update docs/docsite/rst/dev_guide/developing_collections_migrating.rst Co-authored-by: Sandra McCann <samccann@redhat.com> * Mention old collection to update FQCN --------- Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com>
This PR adds related statements that were removed from collection requirements in #1422 and slightly updates the doc