Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable legacy prefix #3020

Closed
wants to merge 4 commits into from

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented Dec 13, 2022

The community has raised various complaints over using the term "legacy" to refer to roles. This PR makes that term configurable in the display so that the community can debate amongst themselves and change it to whatever they want when they reach a consensus.

Due to the lack of support for computed values in enums, the configurable term can't influence the paths in paths.tx, at least not until microsoft/TypeScript#50528 is extended for strings.

image

NOTE: The "standalone" prefix doesn't really make sense in the context of the left nav menu. It would be better if the standalone roles and standalone namespaces fell under the "Collections" NAV and that was renamed.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Dec 13, 2022
@gotmax23
Copy link

NOTE: The "standalone" prefix doesn't really make sense in the context of the left nav menu.

How about

  • Stanadlone Roles
    • Roles
    • Namespaces

@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Dec 14, 2022
@himdel
Copy link
Collaborator

himdel commented Dec 14, 2022

From the l10n pov, this is not so great (translating {foo} Roles separately from Standalone/Legacy is a problem in any language with a concept of gendered nouns), and we will need stable URLs at some point (note that whichever prefix we end up chosing will become an invalid namespace name for collection namespaces, beacuse of the /:namespace/:collection route). (EDIT: the ui is running with the /ui/ prefix, so any /:namespace/:collection redirects need to happen nginx side and won't interfere with the name for legacy)

But if we need to evolve this incrementaly with feedback, LGTM 👍

@himdel
Copy link
Collaborator

himdel commented Jun 13, 2023

Closing, development is moving to https://github.com/ansible/ansible-ui/

@himdel himdel closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants