Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for downstream usage #4916

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix tests for downstream usage #4916

merged 1 commit into from
Mar 11, 2024

Conversation

obaranov
Copy link
Contributor

@obaranov obaranov commented Mar 8, 2024

Added a few minor fixes so we can run UI tests for AAP:

  • Added referer heder to avoid problem with CSRF Failed: Referer checking failed - no Referer
  • Fixed condition for galaxykit execution against HTTPS baseUrl. In that case galaxykit returns 0 code but prints some warnings to the stderr.

@github-actions github-actions bot added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 8, 2024
@obaranov obaranov requested a review from himdel March 8, 2024 18:24
@himdel himdel merged commit 345beca into ansible:master Mar 11, 2024
17 of 18 checks passed
@patchback Patchback
Copy link

patchback bot commented Mar 11, 2024 •
edited
Loading

Backport to stable-4.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.9/345beca06953113e1ec42392747b33a10f0ac7fa/pr-4916

Backported as #4920

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 11, 2024
@obaranov @patchback
Fix tests for downstream usage (#4916)
c9b4039 
No-Issue

(cherry picked from commit 345beca)
@patchback patchback bot mentioned this pull request Mar 11, 2024
Merged
himdel pushed a commit that referenced this pull request Mar 11, 2024
@patchback @obaranov
Fix tests for downstream usage (#4916) (#4920)
3ec68c1 
No-Issue

(cherry picked from commit 345beca)

Co-authored-by: Oleksii Baranov <oleksii.baranov.dev@gmail.com>
@github-actions github-actions bot added the backported-4.9 This PR has been backported to stable-4.9 (2.4) label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.9 This PR should be backported to stable-4.9 (2.4) backported-4.9 This PR has been backported to stable-4.9 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obaranov @himdel