Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix galaxykit: command not found on CI #5014

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented May 3, 2024

Problem:

$ pip install git+https://github.com/ansible/galaxykit.git
Defaulting to user installation because normal site-packages is not writeable
Collecting git+https://github.com/ansible/galaxykit.git
  Cloning https://github.com/ansible/galaxykit.git to /tmp/pip-req-build-o_4bpppk
  Running command git clone --filter=blob:none --quiet https://github.com/ansible/galaxykit.git /tmp/pip-req-build-o_4bpppk
  Resolved https://github.com/ansible/galaxykit.git to commit 9ecb2cd8203b88ad08aa4f[7](https://github.com/ansible/ansible-hub-ui/actions/runs/8903369393/job/24450997489?pr=5003#step:2:8)bbf3a9a70fc4a2046
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml): started
  Building wheel for UNKNOWN (pyproject.toml): finished with status 'done'
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=1597 sha256=ba930e9b2d061[8](https://github.com/ansible/ansible-hub-ui/actions/runs/8903369393/job/24450997489?pr=5003#step:2:9)d7802427669b6a52[9](https://github.com/ansible/ansible-hub-ui/actions/runs/8903369393/job/24450997489?pr=5003#step:2:10)6e9e06c92cc382b29a311afd4c24f0f6b
  Stored in directory: /tmp/pip-ephem-wheel-cache-8f432z66/wheels/d3/56/16/7c88c31fb035860164d9aae593faa487f6ecbccc9324005f6b
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
Successfully installed UNKNOWN-0.0.0

$ galaxykit
galaxykit: command not found

^ this fails on github actions ( https://github.com/ansible/ansible-hub-ui/actions/runs/8903369393/job/24450997489?pr=5003 ), but works locally for me, both with Python 3.11 and Python 3.10.

Likely related to ansible/galaxykit#104


Solution:

trying to see if explicitly installing python 3.11 helps

... it does Successfully installed attrs-23.2.0 certifi-2024.2.2 charset-normalizer-3.3.2 galaxykit-0.14.0 idna-3.7 orionutils-0.1.7 pyyaml-6.0.1 requests-2.31.0 simplejson-3.19.2 urllib3-2.2.1 .. not sure why yet

...Ah...

pre-installed 3.10 uses pip 22 - and breaks
explicitly installed 3.10 uses pip 23 - and works
3.11 uses pip 24 - and works

TODO(me): also update ansible-ui to use the same version (ansible/ansible-ui#1536 set this to my branch, but ansible/galaxykit#99 is merged now)

@himdel himdel added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label May 3, 2024
to fix galaxykit not installing on CI after galaxykit#104

No-Issue
@himdel himdel marked this pull request as ready for review May 3, 2024 18:44
@himdel himdel merged commit 5e305ab into ansible:master May 3, 2024
12 of 13 checks passed
@himdel himdel deleted the fix-galaxykit branch May 3, 2024 18:58
Copy link

patchback bot commented May 3, 2024

Backport to stable-4.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.9/5e305abc93a62eb6e54ada695619b5927d885e4d/pr-5014

Backported as #5016

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 3, 2024
to fix galaxykit not installing on CI after galaxykit#104

No-Issue

(cherry picked from commit 5e305ab)
himdel added a commit that referenced this pull request May 3, 2024
to fix galaxykit not installing on CI after galaxykit#104

No-Issue

(cherry picked from commit 5e305ab)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.9 This PR has been backported to stable-4.9 (2.4) label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.9 This PR should be backported to stable-4.9 (2.4) backported-4.9 This PR has been backported to stable-4.9 (2.4)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant