-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easily disabling some of the rules? #54
Comments
Thanks! At the moment there are a couple of options:
A configuration file would be a good idea - I don't really have time to implement such a feature at the moment but a working pull request would definitely be favourably considered |
I would like this feature as well. Due to some outstanding issues/bugs in the Ansible 1.9 release, it's not always possible to achieve full compliance. As you mention:
I agree having a configuration file would be excellent, even something like .pylintrc. As I understand this is too much work. Would it be easier to add another command line option to allow exclusion based on ANSIBLExxxx? Or, alternatively overload the |
@charleswhchan that's a good idea. I still don't have much time available to look at it, but would support a pull request implementing such a change :) Otherwise, I'll leave this open and see if I get bored at some point! |
@willthames Created PR #73. Please review. |
Thanks @charleswhchan for #73. We might still want a configuration file so I'll leave this open for now. |
No problem. |
Closing this now - if we do want a configuration file, let's have that as a separate issue, preferably as a PR ;) |
As with every linter, this feels like a basic requirement ... |
@aairey and has a basic solution, using Either that or use ansible-review which is much more configurable as to what rules are used. |
Thanks @willthames, I wasn't aware.
Reading this[0] cleared it up for me.
I will switch to ansible-review.
[0]: willthames/ansible-review#31
…On Thu, 29 Mar 2018, 01:26 Will Thames, ***@***.***> wrote:
@aairey <https://github.com/aairey> and has a basic solution, using -x as
per #73 <#73>
Either that or use ansible-review
<https://github.com/willthames/ansible-review> which is much more
configurable as to what rules are used.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHSjvvfzNm1XDCZzD1G22vycdgi2VdB5ks5tjBw2gaJpZM4DrY3S>
.
|
First: thanks for this project!
Now the question:
Is there any less surgical way to disable a rule other than removing it from
/usr/local/lib/python2.7/dist-packages/ansiblelint/rules
?For instance, I really don't care for the trailing whitespace rule, to be honest, so it would be great if people could create a configuration file like you can with jslint or jshint.
Thanks!
The text was updated successfully, but these errors were encountered: