Document syntax-check as unskippable #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/unskippable-rules
branch
from
a6a26c8
to
3401e6f
Compare
ssbarnea
force-pushed
the
fix/unskippable-rules
branch
from
3401e6f
to
ad80111
Compare
felixfontein
approved these changes
Jun 4, 2021
tadeboro
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
It still feels a bit strange that failing the "syntax" check prevents any other errors from being reported. And I placed the syntax part in quotes because Ansible does a lot more in its syntax check. So even if the playbook is valid as far as the syntax goes, the user does not get any diagnostics back.
But this is only weakly related to this PR, and this PR is indeed accurately described the current state of affairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1594