Allow value to be bool where 'yes'/'no' are in choices

[tmshn]

NOTE This pull request work on same issue as #4220 on ansible-modules-core. Therefore, below comment is almost copy-and-paste.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAMES

• ecs_service_facts
• virt_net
• virt_pool
• portage
• nmcli
• debconf

ANSIBLE VERSION

ansible 2.1.0.0
  config file =
  configured module search path = Default w/o overrides

SUMMARY

Many arguments from many modules has limited choices including 'yes' and/or 'no' as a option. However, in some case, these are treated as string type; boolean values cause error.

This pull request fix this problem, in the following two way:

1. Change type to bool

If choices are only 'yes' and 'no', this argument can be easily modified to bool type. Even parameter is passed as string, it will be converted to boolean, so it is 100% backward compatible.

Modules:

• ecs_service_facts
• virt_net
• virt_pool
• nmcli

Example: ecs_service_facts module's case

---
# This still works,
- name: Basic listing example
  ecs_service_facts: details=true # snip...

---
# and this still works too,
- name: Basic listing example
  ecs_service_facts:
    details: "true"
    # snip...

---
# AND! this will work now.
- name: Basic listing example
  ecs_service_facts:
    details: true
    # snip...

2. Add options to catch boolean

UPDATED Thanks to ansible/ansible#16961, this case doesn't need to be considered any more.

If choices contains other values than 'yes' or 'no', this argument should be kept to be treated as string. In this case, if you pass boolean argument here, it will be converted to 'True' or 'False' respectively. Therefore, adding them to the choices will solve the problem.

Modules:

• portage

Example: portage module's case

The choices of sync argument of portage modules contain "web", so it cannot be treated as boolean.

---
# This still works,
- name: sync repositories
  portage: sync=yes

---
# and this still works too,
- name: sync repositories
  portage:
    sync: "yes"

---
# AND! this will work now.
- name: sync repositories
  portage:
    sync: yes

---
# Of course, this
- name: sync repositories via web
  portage: sync=web

---
# or this still works.
- name: sync repositories via web
  portage:
    sync: web

Another example: debconf module's case
The value argument of debconf modules does not have any explicit choices in the modules source code, but actually its choices are limited when vtype is 'boolean'. So I added conversion process here.

[gregdek]

Thanks @tmshn. To the current maintainers, @sayap, @Java1Guy, @alcamie101, @drybjed, @bcoca please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

[tmshn]

Same as ansible/ansible-modules-core#4220, this PR is pended until ansible/ansible#16961 will be merged. needs_revision

[tmshn]

Thanks to @abadger (ansible/ansible#16961), modification for case 2 is meaningless any more. Thus, I dropped commit on packaging/os/portage.py.

Other than that, below modules are welcome for reviews.

Case 1

• ecs_service_facts (e5675b3)
• virt_net & virt_pool (cb5a22b)
• nmcli (46651b5)

Case 3

• debconf (1ee56fb)
  • In debconf's case, the choices are implicit (invisible from ansible module), so still needs conversion.

[abadger]

Thanks @tmshn ! Merged to devel and cherry-picked to stable-2.1.