Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop setuptools_scm_git_archive dependency #1712

Closed
jose1711 opened this issue Mar 11, 2024 · 1 comment · Fixed by #1716
Closed

Drop setuptools_scm_git_archive dependency #1712

jose1711 opened this issue Mar 11, 2024 · 1 comment · Fixed by #1716
Labels
bug Researched, reproducible, committed to fix

Comments

@jose1711
Copy link
Contributor

ISSUE TYPE
  • Bug Report
SUMMARY

As per "With setuptools-scm >= 7.0.0 the separate use of setuptools-scm-git-archive has become obsolete, as the functionality is now included." at https://archlinux.org/todo/remove-use-of-python-setuptools-scm-git-archive/ it looks like setuptools_scm_git_archive is no longer needed with almost a 2-year old setuptools-scm (version 7.0.0 was released in June 2022). FWIW the project builds without issues if said module is removed from pyproject.toml.

ANSIBLE-NAVIGATOR VERSION

current HEAD
@jose1711 jose1711 added bug Researched, reproducible, committed to fix new New issues and PRs to triaged labels Mar 11, 2024
@ssbarnea
Copy link
Member

@jose1711 You are right. Can you please make a PR to address it?

@ssbarnea ssbarnea removed the new New issues and PRs to triaged label Mar 12, 2024
jose1711 added a commit to jose1711/ansible-navigator that referenced this issue Mar 15, 2024
@jose1711
drop setuptools_scm_git_archive
8f98435 
fixes ansible#1712
@jose1711 jose1711 mentioned this issue Mar 15, 2024
Merged
shatakshiiii pushed a commit to jose1711/ansible-navigator that referenced this issue Mar 15, 2024
@jose1711 @shatakshiiii
drop setuptools_scm_git_archive
63851b4 
fixes ansible#1712
shatakshiiii pushed a commit that referenced this issue Mar 16, 2024
@jose1711
drop setuptools_scm_git_archive (#1716)
dccb393 
fixes #1712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Researched, reproducible, committed to fix
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drop setuptools_scm_git_archive jose1711/ansible-navigator
2 participants
@ssbarnea @jose1711