Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAH-2509] Hub > My imports page #1473

Merged
merged 22 commits into from
Jan 31, 2024
Merged

Conversation

jerabekjiri
Copy link
Contributor

@jerabekjiri jerabekjiri commented Jan 17, 2024

Issue: AAH-2509

completed collection import:
Screenshot from 2024-01-17 15-47-21

failed collection import:
Screenshot from 2024-01-21 18-42-23

empty collection import:
Screenshot from 2024-01-21 19-06-07

server error loading collection imports:
Screenshot from 2024-01-21 00-15-22

@github-actions github-actions bot added E2E End-to-end testing AFW Ansible Framework labels Jan 17, 2024
@jerabekjiri jerabekjiri removed E2E End-to-end testing AFW Ansible Framework labels Jan 17, 2024
@github-actions github-actions bot added E2E End-to-end testing AFW Ansible Framework labels Jan 21, 2024
Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @jerabekjiri, one comment about a leftover file.

framework/components/ImportLog.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the AFW Ansible Framework label Jan 24, 2024
@jerabekjiri jerabekjiri force-pushed the jerabekjiri-my-imports-screen branch 6 times, most recently from 3f86d71 to c70d63b Compare January 27, 2024 22:01
@himdel
Copy link
Contributor

himdel commented Jan 28, 2024

I think I managed to fix approvals.cy in 3b5275f 🤞 if it helps with the tests :)

@jerabekjiri
Copy link
Contributor Author

@himdel I was trying to fix failing my-imports tests, but you made the rest green, thanks 👍

@himdel
Copy link
Contributor

himdel commented Jan 29, 2024

One more thing (but probably for a separate PR) .. in light mode:

my imports:
20240129192343

collection import log:
20240129192528

I think we need to make both these views use the same colors (and components)
and it's probably better to make my-imports have dark background,
but if you want to keep the light background, the orange needs to be darker

@jerabekjiri
Copy link
Contributor Author

@himdel good catch, I'll address this in a different PR :)

@jerabekjiri jerabekjiri merged commit 1ad6364 into main Jan 31, 2024
15 checks passed
@jerabekjiri jerabekjiri deleted the jerabekjiri-my-imports-screen branch January 31, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E End-to-end testing HUB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants