Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-25497] Fix Disappearing Credential Select #2565

Merged
merged 25 commits into from
Jul 9, 2024

Conversation

prat98
Copy link
Contributor

@prat98 prat98 commented Jun 20, 2024

This PR is for AAP-25497. It fixes the disappearing credential select downstream by updating to the using the new PageFormMultiSelectAwxResource component. In addition, it also updates the MultiSelectDialog component to build a queryparam object from the passed url prop and the queryParam prop.

@prat98 prat98 self-assigned this Jun 20, 2024
@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label Jun 20, 2024
@marshmalien
Copy link
Member

I know this is still a WIP, but wanted to point out that some work will need to be done in the forms to render the credential labels properly.

Screenshot 2024-06-24 at 2 40 24 PM

@prat98 prat98 force-pushed the aap-25497-fix-disappearing-credential-select branch 2 times, most recently from c4392a6 to b2d804e Compare June 25, 2024 14:45
@h-kataria h-kataria added the release-blocker Release Blocker label Jun 26, 2024
@github-actions github-actions bot added the E2E End-to-end testing label Jun 26, 2024
@prat98 prat98 marked this pull request as ready for review June 26, 2024 20:23
@prat98
Copy link
Contributor Author

prat98 commented Jun 26, 2024

I know this is still a WIP, but wanted to point out that some work will need to be done in the forms to render the credential labels properly.

Screenshot 2024-06-24 at 2 40 24 PM

Just pushed a fix for this

Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One thing I noticed is that when you select one or more credentials, the field appears like so:
image

Is it possible to make the chips larger to show at least part of the credential names?

Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing these changes, I unfortunately just witnessed the original behavior. To reproduce:

  1. Access the job template create form
  2. In the credential field, select one or more credentials
  3. Now, in the field where you see the chips, click one of the x's inside the chips. The dropdown will appear automatically. Click the 'Browse' button
  4. The modal to select Credentials will appear, and in a few seconds will disappear

@prat98
Copy link
Contributor Author

prat98 commented Jul 2, 2024

Nice work! One thing I noticed is that when you select one or more credentials, the field appears like so: image

Is it possible to make the chips larger to show at least part of the credential names?

I can't reproduce this issue for some reason, what was your specific testing environment?

@acruzgon
Copy link
Contributor

acruzgon commented Jul 2, 2024

I see this behavior if you click on the Brown button to add a credential. An X is rendering instead of the credential label.

Screenshare.-.2024-07-02.10_16_34.AM.mp4

@prat98 prat98 force-pushed the aap-25497-fix-disappearing-credential-select branch from 4d0b693 to 06f1fe6 Compare July 2, 2024 21:29
@github-actions github-actions bot removed the AFW Ansible Framework label Jul 2, 2024
@github-actions github-actions bot added the AFW Ansible Framework label Jul 5, 2024
@prat98 prat98 force-pushed the aap-25497-fix-disappearing-credential-select branch from 560ec3a to 8cbb9ee Compare July 5, 2024 21:05
@prat98 prat98 force-pushed the aap-25497-fix-disappearing-credential-select branch from 74fb39d to b6884ad Compare July 8, 2024 16:25
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prat98 great job. A few minor suggestions.

@prat98
Copy link
Contributor Author

prat98 commented Jul 9, 2024

In testing these changes, I unfortunately just witnessed the original behavior. To reproduce:

  1. Access the job template create form
  2. In the credential field, select one or more credentials
  3. Now, in the field where you see the chips, click one of the x's inside the chips. The dropdown will appear automatically. Click the 'Browse' button
  4. The modal to select Credentials will appear, and in a few seconds will disappear

This issue will remain for now as the old problematic instance group select lookup is also on the job template form. These issues should be fixed once that look up is updated in another PR

@prat98 prat98 dismissed akus062381’s stale review July 9, 2024 19:29

Addressed in comment. The issue brought up is valid the disappearing modal issue still exists but will be fully fixed once the instance group lookup is updated

@prat98 prat98 merged commit bc74abf into main Jul 9, 2024
23 checks passed
@prat98 prat98 deleted the aap-25497-fix-disappearing-credential-select branch July 9, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AFW Ansible Framework AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing release-blocker Release Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants