-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-25497] Fix Disappearing Credential Select #2565
Conversation
c4392a6
to
b2d804e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing these changes, I unfortunately just witnessed the original behavior. To reproduce:
- Access the job template create form
- In the credential field, select one or more credentials
- Now, in the field where you see the chips, click one of the x's inside the chips. The dropdown will appear automatically. Click the 'Browse' button
- The modal to select Credentials will appear, and in a few seconds will disappear
I see this behavior if you click on the Brown button to add a credential. An X is rendering instead of the credential label. Screenshare.-.2024-07-02.10_16_34.AM.mp4 |
4d0b693
to
06f1fe6
Compare
560ec3a
to
8cbb9ee
Compare
74fb39d
to
b6884ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
….com:ansible/ansible-ui into aap-25497-fix-disappearing-credential-select
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prat98 great job. A few minor suggestions.
frontend/awx/access/credentials/components/PageFormCredentialSelect.tsx
Outdated
Show resolved
Hide resolved
This issue will remain for now as the old problematic instance group select lookup is also on the job template form. These issues should be fixed once that look up is updated in another PR |
Addressed in comment. The issue brought up is valid the disappearing modal issue still exists but will be fully fixed once the instance group lookup is updated
This PR is for AAP-25497. It fixes the disappearing credential select downstream by updating to the using the new
PageFormMultiSelectAwxResource
component. In addition, it also updates theMultiSelectDialog
component to build a queryparam object from the passed url prop and the queryParam prop.