netconf_config: Always stacktraces on using backup: yes (i.e. example cannot ever work)

[eikef]

SUMMARY

The backup parameter for netconf_config cannot ever work if set to yes. This is due to the code in the netconf_config module throwing a stacktrace whenever it is set. The module_utils/netconf/netconf.py provides a get_config method, but it requires an additional parameter of "filter", which is not set in netconf_config when trying to obtain the current configuration for backup purposes.

ISSUE TYPE

• Bug Report

COMPONENT NAME

netconf_config

ANSIBLE VERSION

ansible 2.8.0rc1.post0

STEPS TO REPRODUCE

Minimal example playbook:

- name: save config
  netconf_config:
    backup: yes

(note that this is a minimalized version of the last example shipped with the documentation of the netconf_config module).

EXPECTED RESULTS

Backup of NETCONF configuration is saved somewhere.

ACTUAL RESULTS

TASK [switch : save config] ************************************************************************************************************************************
task path: /home/XXX/roles/switch/tasks/main.yml:29
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: TypeError: get_config() takes at least 3 arguments (3 given)
fatal: [switch01]: FAILED! => changed=false
  module_stderr: |-
    Traceback (most recent call last):
      File "/home/XXX/.ansible/tmp/ansible-local-68072FPzspT/ansible-tmp-1556809036.71-228316506197860/AnsiballZ_netconf_config.py", line 114, in <module>
        _ansiballz_main()
      File "/home/XXX/.ansible/tmp/ansible-local-68072FPzspT/ansible-tmp-1556809036.71-228316506197860/AnsiballZ_netconf_config.py", line 106, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File "/home/XXX/.ansible/tmp/ansible-local-68072FPzspT/ansible-tmp-1556809036.71-228316506197860/AnsiballZ_netconf_config.py", line 49, in invoke_module
        imp.load_module('__main__', mod, module, MOD_DESC)
      File "/tmp/ansible_netconf_config_payload_VY5Wfu/__main__.py", line 439, in <module>
      File "/tmp/ansible_netconf_config_payload_VY5Wfu/__main__.py", line 367, in main
    TypeError: get_config() takes at least 3 arguments (3 given)
  module_stdout: ''
  msg: |-
    MODULE FAILURE
    See stdout/stderr for the exact error
  rc: 1

[ansibot]

Files identified in the description:

• lib/ansible/modules/network/netconf/netconf_config.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @lpenz @rcarrillocruz @trishnaguha @userlerueda
click here for bot help

[ansibot]

@eikef, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help