Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support glob pattern for creates= and removes= #24690

Closed
wants to merge 1 commit into from
Closed

Support glob pattern for creates= and removes= #24690

wants to merge 1 commit into from

Conversation

ballessay
Copy link

SUMMARY

To be consistent with the command module allow glob patterns as the
creates and removes module parameters.

Use case was a command that creates a seemingly random named file (hash?) in a known subfolder.

I haven't found a related issue after a quick search.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/commands/expect.py

ANSIBLE VERSION
devel 2.4
ADDITIONAL INFORMATION

Executing a svn update filling in the username password, a file gets created under $HOME/.subversion/auth/svn.simple/$HASH

Before this change the solution seemed to be to run a pre-task, like:

- shell: ls $HOME/.subversion/auth/svn.simple/
  register: var

- expect: ...
  creates: {{ var.stdout }}

@sivel
Copy link
Member

sivel commented May 16, 2017

This requires documentation indicating that glob functionality is added in 2.4.

Similarly to what was done with command: 3b93401

needs_revision

@ballessay
Copy link
Author

Thanks for your fast response. I'll add that. Is it ok if add all to one commit?

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 16, 2017
@ballessay
Copy link
Author

Documentation is now extended with the version information.

@ballessay
Copy link
Author

bot_status

@ballessay
Copy link
Author

ready_for_review

@ansibot
Copy link
Contributor

ansibot commented May 25, 2017

waiting_on: maintainer
module: expect
supported_by: community
maintainers: sivel
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: 0
community_shipits: 0
ansible_shipits: 0
shipit_actors: []

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 25, 2017
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 23, 2017
@ballessay ballessay closed this Jul 1, 2017
@ballessay ballessay reopened this Jul 1, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 1, 2017
@ballessay
Copy link
Author

ready_for_review

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 18, 2017
To be consistent with the command module add glob patterns to the
creates and removes module parameters.
@ansibot ansibot removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 22, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 22, 2017
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 29, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Feb 6, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2018
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 10, 2018
@ansibot ansibot added the commands Commands category label Mar 5, 2019
@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Jul 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@ballessay Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added the needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. label Jul 31, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@ballessay Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 3, 2019
@gundalow
Copy link
Contributor

@ballessay
Thank you for your PR.
As part of reviewing the backlog of PRs we are looking at PRs older PRs that haven't been updated in a while

Given that:

  • No update since 2017
  • This is a feature rather than a bug fix
  • The source branch (in your fork) no longer exists

Therefore I'm going to close this.

If you or anyone else wants to continue with this work then please do feel free to create a fresh PR and @mention the previous reviewers in here.

@gundalow gundalow closed this Sep 19, 2019
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 commands Commands category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. new_contributor This PR is the first contribution by a new community member. pr_day Has been reviewed during a PR review Day stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants