Module for running templates and workflows on vDirect

[evgenyfedoruk]

Modure for running configuration templates and workflows on Radware vDirect server

SUMMARY

This is a second module for Radware vDirect server. This module allows to run
configuration templates, create workflows and run actions of existing workflows in vDirect server

COMPONENT NAME

vdirect_runnable

ANSIBLE VERSION

2.3.2.0

ADDITIONAL INFORMATION

[ansibot]

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc vdirect_runnable" returned exit status 1.
>>> Standard Error
ERROR! module vdirect_runnable missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc vdirect_runnable" returned exit status 1.
>>> Standard Error
ERROR! module vdirect_runnable missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc vdirect_runnable" returned exit status 1.
>>> Standard Error
ERROR! module vdirect_runnable missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc vdirect_runnable" returned exit status 1.
>>> Standard Error
ERROR! module vdirect_runnable missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test pylint [?] failed with the following errors:

test/units/modules/network/radware/test_vdirect_runnable.py:116:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'KeyError was not thrown for missing parameter'
test/units/modules/network/radware/test_vdirect_runnable.py:140:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'MissingRunnableException was not thrown for missing runnable name'
test/units/modules/network/radware/test_vdirect_runnable.py:176:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'WrongActionNameException was not thrown for wrong action name'
test/units/modules/network/radware/test_vdirect_runnable.py:201:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'MissingActionParametersException was not thrown for missing parameters'
test/units/modules/network/radware/test_vdirect_runnable.py:210:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'MissingActionParametersException was not thrown for missing parameters'
test/units/modules/network/radware/test_vdirect_runnable.py:269:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'RunnableException was not thrown for failed run.'
test/units/modules/network/radware/test_vdirect_runnable.py:279:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'RunnableException was not thrown for failed run.'

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/network/radware/vdirect_runnable.py:0:0: E305 DOCUMENTATION.options.parameters.description.2: expected str @ data['options']['parameters']['description'][2]. Got {'For example': "... parameters={'adc':[{'type':'Container','name':'VX-73'}]}"}

click here for bot help

[mattclay]

CI failure in unit tests (in addition to already noted sanity test failures):

>       return 'Reason: {}. Details:{}.'.format(self.reason, self.details)
E       ValueError: zero length field name in format

lib/ansible/modules/network/radware/vdirect_runnable.py:204: ValueError

[ansibot]

@evgenyfedoruk

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

[gundalow]

I wonder if this should go into lib/ansible/modules/cloud/vmware/?
@jctanner

[gundalow]

Hi,
Please ignore the above it does belong in lib/ansible/modules/network

[evgenyfedoruk]

shipit

[gundalow]

Hi,
Why are you prefixing most of the module option names with vdirect_?
needs_info.

[gundalow]

C(VDIRECT_IP)
http://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#formatting-options

[evgenyfedoruk]

Thanks,
will fix it on next commit.

I prefix all parameters with "vdirect_" to keep it similar to environment variables that may be used instead of specifying the parameter. vdirect is the back-end system the module communicates with for all operations.

[evgenyfedoruk]

This module is a WIP for now. This will be modified. Please do not review yet

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/network/radware/vdirect_runnable.py:279:40: W503 line break before binary operator

click here for bot help

[gundalow]

Updated title to say it's [WIP], please update this when you are ready for review.

If you need assistance in the meantime feel free to join in #ansible-network on Freenode IRC.

[evgenyfedoruk]

WIP removed. Ready for review

[gundalow]

Merged into devel will be released in 2.5.0