Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_logging: change IOS command pipe to section to include #33100

Merged
merged 1 commit into from
Nov 21, 2017
Merged

ios_logging: change IOS command pipe to section to include #33100

merged 1 commit into from
Nov 21, 2017

Conversation

steveglen
Copy link
Contributor

This improves compatibility with older IOS devices which do not
support "section" but "include" has been supported for a lot longer.

SUMMARY

We support a mix of old and new Cisco devices, and some are currently running software trains that don't support the section command (e.g. 3750 switches). This change allows the module to run on these platforms.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_logging

@steveglen
ios_logging: change IOS command pipe to section to include
5186848 
This improves compatibility with older IOS devices which do not
support "section" but "include" has been supported for a lot longer.
@ansibot
Copy link
Contributor

ansibot commented Nov 20, 2017

cc @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Nov 20, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Nov 20, 2017
@trishnaguha trishnaguha merged commit a6e425e into ansible:devel Nov 21, 2017
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Nov 21, 2017
@steveglen @trishnaguha
ios_logging: change IOS command pipe to section to include (ansible#3…
c047075 
…3100)

This improves compatibility with older IOS devices which do not
support "section" but "include" has been supported for a lot longer.
(cherry picked from commit a6e425e)
trishnaguha added a commit that referenced this pull request Nov 21, 2017
@trishnaguha
ios_logging: change IOS command pipe to section to include (#33100) (#…
b0404db 
…33116)

This improves compatibility with older IOS devices which do not
support "section" but "include" has been supported for a lot longer.
(cherry picked from commit a6e425e)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveglen @ansibot @trishnaguha @dagwieers @bcoca