Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_facts fix NameError #48981

Merged
merged 1 commit into from
Nov 27, 2018
Merged

nxos_facts fix NameError #48981

merged 1 commit into from
Nov 27, 2018

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

Fixes #48369

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_facts.py

ADDITIONAL INFORMATION

@trishnaguha
nxos_facts fix NameError
43f1adb 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha mentioned this pull request Nov 21, 2018
Closed
@trishnaguha trishnaguha self-assigned this Nov 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

Hi @trishnaguha, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

cc @mikewiebe @rahushen @rcarrillocruz @tstoner
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Nov 21, 2018
@trishnaguha trishnaguha merged commit 8796085 into ansible:devel Nov 27, 2018
@trishnaguha trishnaguha deleted the nxos_facts_NameError branch November 27, 2018 04:44
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Nov 29, 2018
@trishnaguha
nxos_facts fix NameError (ansible#48981)
364f577 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8796085)
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Nov 29, 2018
@trishnaguha
nxos_facts fix NameError (ansible#48981)
a664b42 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8796085)
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@trishnaguha @mjmayer
nxos_facts fix NameError (ansible#48981)
a0c3eda 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
abadger pushed a commit that referenced this pull request Dec 4, 2018
@trishnaguha @abadger
nxos_facts fix NameError (#48981)
029880a 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8796085)
mattclay pushed a commit that referenced this pull request Dec 10, 2018
@trishnaguha @mattclay
nxos_facts fix NameError (#48981)
30b7f83 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8796085)
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_facts: " NameError: global name 'objects' is not defined" on NXOS 7.0
3 participants
@trishnaguha @ansibot @dagwieers