Pick 26 nxos bugs #49280
Merged
Pick 26 nxos bugs #49280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use expect module to copy files * Remove old and redundant upgrade files * Return error message instead of code * Cleanup copy command code * Fix force issue in nxos_install_os * new nxos_install_os integration tests * Uncomment transport tests * Revert negative test change * Remove combined option that is no longer required * Make shippable happy * Add n5k test files (cherry picked from commit a721572)
* nxos_interface vlan and port-channel idempotence fix for mtu * Fix MTU reconfiguration at each execution * nxos_interface port-channel idempotence fix for mode (ansible#44248) * Fix trunk mode idempotence for port-channel * Gather ethernet and port-channel code for mode management * nxos_linkagg port-channel idempotence fix for channel-group's mode The regex to retrieve channel-group's mode is not enough accurate. Therefore, the swhitchport mode was matched instead of the channel-group's mode. * This fix add accuracy to match the right configuration command * Add support for switchport mode dot1q-tunnel in nxos_interface * Fix layer reconfiguration at each execution (cherry picked from commit c51407c)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 8796085)
(cherry picked from commit e51964e)
* nxos_facts: Remove dead code The commit e51964e made this redundant as the structured case is handled elsewhere. * nxos_facts: Do not gather neighbors redundantly LLDP reports the neighbor using the abbreviated interface name, whereas CDP reports the neighbor using the full interface name. Normalize the local interface name in the LLDP case, so there is no redundant information. Due to the order of the gathering, CDP neighbors are saved in case both LLDP and CDP data is available on a certain interface. (cherry picked from commit 2019f0e)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 27075ab)
(cherry picked from commit e51964e)
(cherry picked from commit af1e687)
|
Hi @trishnaguha, thank you for submitting this pull-request! |
ansibot
added
affects_2.6
|
The test |
ansibot
added
ci_verified
trishnaguha
force-pushed
the
pick_26_nxos_bugs
branch
from
3da8f09
to
e5b6d0f
Compare
ansibot
added
core_review
trishnaguha
removed
the
needs_triage
ansibot
added
the
stale_ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Pick 26 nxos bugs
ISSUE TYPE