New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick 26 nxos bugs #49280

Open
wants to merge 9 commits into
base: stable-2.6
from

Conversation

Projects
None yet
6 participants
@trishnaguha
Member

trishnaguha commented Nov 29, 2018

SUMMARY

Pick 26 nxos bugs

ISSUE TYPE
  • Bugfix Pull Request

mikewiebe and others added some commits Nov 20, 2018

Fix issues with nxos_os_install module (#48811)
* Use expect module to copy files

* Remove old and redundant upgrade files

* Return error message instead of code

* Cleanup copy command code

* Fix force issue in nxos_install_os

* new nxos_install_os integration tests

* Uncomment transport tests

* Revert negative test change

* Remove combined option that is no longer required

* Make shippable happy

* Add n5k test files

(cherry picked from commit a721572)
Fix nxos modules idempotence issue (#46437)
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution

(cherry picked from commit c51407c)
nxos_facts fix NameError (#48981)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8796085)
Fix LLDP to use json (#48318)
(cherry picked from commit e51964e)
nxos_facts: Do not gather redundant neighbor data (#49024)
* nxos_facts: Remove dead code

The commit e51964e made this redundant as the structured case is handled
elsewhere.

* nxos_facts: Do not gather neighbors redundantly

LLDP reports the neighbor using the abbreviated interface name, whereas
CDP reports the neighbor using the full interface name. Normalize the
local interface name in the LLDP case, so there is no redundant
information. Due to the order of the gathering, CDP neighbors are saved
in case both LLDP and CDP data is available on a certain interface.

(cherry picked from commit 2019f0e)
do not override lldp neighbors nxos_facts (#48087)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 27075ab)
Fix LLDP to use json (#48318)
(cherry picked from commit e51964e)
Fix n3k power supply facts (#49150)
(cherry picked from commit af1e687)
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 29, 2018

Hi @trishnaguha, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 29, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_facts.py:420:5: E303 too many blank lines (2)

click here for bot help

changelog
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:pick_26_nxos_bugs branch from 3da8f09 to e5b6d0f Nov 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 7, 2018

@ansibot ansibot added the stale_ci label Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment