Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Adds banner for core/package split #73552

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Docs: Adds banner for core/package split #73552

merged 2 commits into from
Feb 23, 2021

Conversation

acozine
Copy link
Contributor

@acozine acozine commented Feb 9, 2021

SUMMARY

Adds a banner published only on the docs.ansible.com/ansible-core/ pages that gives readers a link to the main package docsite.

Closes #73197.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com/ansible-core

@acozine
Copy link
Contributor Author

acozine commented Feb 9, 2021

Related to #73421, #73362, and/or #73299.

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.11 docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 9, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 11, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 19, 2021
@acozine acozine force-pushed the banner-for-core-package-split branch from 52a73f1 to f9f0ecc Compare February 23, 2021 20:11
@acozine acozine force-pushed the banner-for-core-package-split branch from f9f0ecc to 343b7f5 Compare February 23, 2021 20:14
@acozine acozine changed the title WIP: Banner for core package split Adds banner for core package split Feb 23, 2021
@acozine acozine changed the title Adds banner for core package split DOCS: Adds banner for core/package split Feb 23, 2021
@acozine acozine changed the title DOCS: Adds banner for core/package split Docs: Adds banner for core/package split Feb 23, 2021
@acozine acozine removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Feb 23, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 23, 2021
samccann
samccann approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified for core docs and Ansible docs

@samccann samccann merged commit 29d3951 into ansible:devel Feb 23, 2021
@samccann samccann mentioned this pull request Mar 1, 2021
Closed
3 tasks
@ansible ansible locked and limited conversation to collaborators Mar 23, 2021
@acozine acozine deleted the banner-for-core-package-split branch April 30, 2021 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2]Create banners to differentiate core from Ansible docs
4 participants
@acozine @samccann @bcoca @ansibot